Route all Rocket internal logs through gem_tracing#975
Draft
Conversation
Changed Files
|
Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error logging format for device not found
Use gem_tracing for device auth guard error logging
Feb 28, 2026
…acing Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
…able via ROCKET_LOG_LEVEL env var Co-authored-by: gemcoder21 <104884878+gemcoder21@users.noreply.github.com>
Copilot
AI
changed the title
Use gem_tracing for device auth guard error logging
Route all Rocket internal logs through gem_tracing
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rocket's internal log events (guard failures, 404s, catcher responses) were emitted via its own
RocketLoggerwith a>prefix format, inconsistent with the project'sgem_tracingstructured output.Root cause
Rocket 0.5 uses the
logcrate and registersRocketLoggervialog::set_boxed_logger— a one-time global. Nothing previously claimed that slot first.Changes
crates/tracing— addlog = "0.4"dep; implementGemLogger(log::Log) that converts everylogevent into atracingevent routed through the existingFmtSubscriber; exposeinit()which registersGemLoggerand sets the level filter fromROCKET_LOG_LEVELenv var (default:normal; values:off/critical/normal/debug)apps/api/src/main.rs— callgem_tracing::init()at the top ofmain(), before anyrocket::build(). Rocket's subsequentset_boxed_loggercall silently fails (already taken), so its events flow throughGemLoggerapps/api/src/devices/guard.rs— explicitly log auth guard failures viainfo_with_fields!with structured fields (uri,status,error,user_agent) before the guard returns an error outcomeResult
Rocket's
"Request guard \AuthenticatedDevice` failed: ..."and similar messages now emit in the same format as all other application logs. Log verbosity is runtime-configurable viaROCKET_LOG_LEVEL`.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.rocket.rs/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.