Skip to content

Update error state views to use dynamic titles #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DRadmir merged 1 commit into from
Jan 27, 2026
Merged

Update error state views to use dynamic titles #1632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Features/MarketInsight/Sources/Scenes/ChartScene.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ public struct ChartScene: View {
model: AssetPriceDetailsViewModel(priceData: priceData)
)
}
.presentationDetentsForCurrentDeviceSize(expandable: true)
.presentationBackground(Colors.grayBackground)
}
}
Expand Down
3 changes: 1 addition & 2 deletions Features/Perpetuals/Sources/Scenes/PerpetualScene.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public struct PerpetualScene: View {
case .data(let data): CandlestickChartView(data: data, period: model.currentPeriod, lineModels: model.chartLineModels)
case .error(let error):
StateEmptyView(
title: Localized.Errors.errorOccured,
description: error.networkOrNoDataDescription,
title: error.networkOrNoDataDescription,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While moving error.networkOrNoDataDescription to the title parameter makes the title dynamic, it's generally better practice to use a concise, generic title for error states (e.g., 'An error occurred!') and provide the specific details in the description parameter. This improves readability and user experience, especially if networkOrNoDataDescription can be verbose. The StateEmptyView is designed to accommodate both a title and a description.

Suggested change
title: error.networkOrNoDataDescription,
title: Localized.Errors.errorOccured,
description: error.networkOrNoDataDescription,

image: Images.ErrorConent.error
)
}
Expand Down
3 changes: 1 addition & 2 deletions Packages/PrimitivesComponents/Sources/Views/ChartStateView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ public struct ChartStateView: View {
ChartView(model: model)
case .error(let error):
StateEmptyView(
title: Localized.Errors.errorOccured,
description: error.networkOrNoDataDescription,
title: error.networkOrNoDataDescription,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the change in PerpetualScene.swift, using error.networkOrNoDataDescription directly as the title might make the title too long or less user-friendly. It's recommended to keep a generic error title and use the description parameter for the specific error details provided by error.networkOrNoDataDescription. This maintains a consistent and clear error presentation.

Suggested change
title: error.networkOrNoDataDescription,
title: Localized.Errors.errorOccured,
description: error.networkOrNoDataDescription,

image: Images.ErrorConent.error
)
}
Expand Down