Remove WalletsService facade, inject services directly into consumers#1730
Merged
Remove WalletsService facade, inject services directly into consumers#1730
Conversation
Replace the monolithic WalletsService facade with direct injection of focused services: AssetsEnabler, AssetSyncServiceable, BalanceService, WalletSetupService, and WalletSessionService. Each consumer now depends only on the protocols it actually uses.
Contributor
Summary of ChangesHello @DRadmir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant refactoring of the wallet-related services. The primary goal is to decompose the large Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully removes the monolithic WalletsService facade and replaces it with direct injection of more focused services: AssetsEnabler, AssetSyncServiceable, BalanceService, WalletSetupService, and WalletSessionService. This refactoring significantly improves the modularity and testability of the codebase by adhering to the Interface Segregation Principle. The changes are thorough, covering view models, navigation stacks, and service factories, while maintaining existing logic and ensuring that consumers only depend on the protocols they actually use.
…llets-service-facade
Replace the AssetSyncServiceable facade (which bundled balance updates, price updates, and asset discovery) with direct injection of BalanceUpdater and PriceUpdater into consumers, and a focused AssetDiscoveryService for wallet asset discovery only. - Rename WalletAssetSyncService → AssetDiscoveryService (AssetDiscoverable protocol) - Remove pass-through updateAssets/addPrices methods - Inject BalanceUpdater directly into AssetSceneViewModel, SwapSceneViewModel, WalletSceneViewModel - Inject PriceUpdater directly into SwapSceneViewModel - Delete unused DiscoveryAssetsProcessing protocol - Add BalanceUpdaterMock and PriceUpdaterMock
gemdev111
reviewed
Feb 26, 2026
gemdev111
reviewed
Feb 26, 2026
gemdev111
reviewed
Feb 26, 2026
gemdev111
reviewed
Feb 26, 2026
gemdev111
approved these changes
Feb 26, 2026
… protocol - Move wallet parameter into TestKit mock, remove duplicate from tests - Use `any WalletSessionManageable` instead of concrete WalletSessionService in Environment, AppResolver, and SettingsViewModel - Add walletsCount/hasMulticoinWallet as default protocol implementations
…llets-service-facade
DRadmir
force-pushed
the
remove-wallets-service-facade
branch
from
7672e2e to
e40fede
Compare
…ural homes Move AssetsEnablerService to BalanceService, AssetDiscoveryService to DiscoverAssetsService, WalletSetupService to WalletService, and PriceUpdater to PriceService. Remove BalanceUpdateService adapter by having consumers pass Wallet directly instead of WalletId. Fix BalancerUpdater typo.
DRadmir
force-pushed
the
remove-wallets-service-facade
branch
from
e40fede to
edb7178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the monolithic WalletsService facade with direct injection of focused services: AssetsEnabler, AssetSyncServiceable, BalanceService, WalletSetupService, and WalletSessionService. Each consumer now depends only on the protocols it actually uses.