-
Notifications
You must be signed in to change notification settings - Fork 11
Use collection for properties and pass context to called object #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dalvarellos
wants to merge
8
commits into
master
Choose a base branch
from
fix/impove-dynamicCall-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta success |
claudiamurialdo
previously approved these changes
Nov 22, 2024
…f GenexsCore Module.
Cherry pick to beta success |
Note There is an error in the build of GeneXus module because of this change. (Issue number is missed) |
…in backward compatibility with the GeneXus Core module.
Cherry pick to beta success |
Cherry pick to beta success |
Cherry pick to beta success |
claudiamurialdo
previously approved these changes
Dec 2, 2024
Added missing using directives and a public AssemblyName constant. Fixed property setters for Properties and ExtendedProperties. Enhanced VerifyDefaultProperties to use the AssemblyName constant, improved cross-platform assembly loading logic, and added better exception handling for load failures. These changes improve correctness, maintainability, and compatibility.
Cherry pick to beta failed, 1 conflicted file in commit 58ef1f4
|
Cherry pick to beta failed, 0 conflicted files in commit 58ef1f4 (warning: no changes merged) |
Manual cherry pick to beta success |
Changed stackTrace.GetFrame from (2) to (5) when retrieving the calling method's assembly in .NET Core. This ensures the correct assembly is identified by accounting for changes in the call stack structure.
Cherry pick to beta success |
Refactor GxDynamicCall to introduce explicit AssemblyNameProperty and NamespaceProperty constants, with a default namespace ("GeneXus.Programs"). Update logic to allow dynamic specification of assembly and namespace via properties, and adjust object name resolution and ClassLoader usage accordingly. Improves flexibility and clarity in dynamic invocation.
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.