Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Font disposing if FontFamily is not set #21

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix Font disposing if FontFamily is not set #21

merged 1 commit into from
Feb 20, 2025

Conversation

damiansalvia
Copy link
Collaborator

The dispose of a Font instance raises an exception if the associated FontFamily is null.

gusmar1972
gusmar1972 approved these changes Feb 20, 2025
View reviewed changes
Copy link

@gusmar1972 gusmar1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damiansalvia damiansalvia merged commit d9a18f7 into main Feb 20, 2025
3 checks passed
@damiansalvia damiansalvia deleted the fix/font-dispose branch February 20, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusmar1972 gusmar1972 gusmar1972 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiansalvia @gusmar1972