Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements over Color struct #6

Merged
merged 18 commits into from
Jun 13, 2024
Merged

Improvements over Color struct #6

merged 18 commits into from
Jun 13, 2024

Conversation

damiansalvia
Copy link
Collaborator

Several improvements over Color struct

  • Implement missing methods and properties
  • Add KnownColor enum
  • Fix some typos

@damiansalvia damiansalvia requested a review from fedeazzato June 4, 2024 18:34
fedeazzato
fedeazzato approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@fedeazzato fedeazzato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

I took the liberty to make some changes. Hope you're 🆗 with them. If you don't like them we can revert them and discuss them properly.

@damiansalvia
Copy link
Collaborator Author

Thanks!

I just leave a comment fa6fabf#commitcomment-143048583 because I'm still not sure about this little change, and maybe we have to discuss it further.

@damiansalvia damiansalvia merged commit b3ded49 into main Jun 13, 2024
1 check passed
@damiansalvia damiansalvia deleted the feature/color branch June 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeazzato fedeazzato fedeazzato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiansalvia @fedeazzato