Add gnustl vector and map (and a lot of other dependencies those have) #1255
+8,459
−1,233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how does this differ from the existing gnustl map implementation? |
Building PersistenceAPI (my mod) with the old implementation for vector/map resulted in random crashes that appeared to be memory corruption. I wasn't able to pinpoint the exact cause but using this "official" gnustl implementation fixed those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a lot of new code that I copied from the gcc libstdc++v3 at the first commit of 2014. I don't expect this to get merged soon but if someone else cares about this and bothers to check nothing breaks because of it then I'm all for it getting merged. Some mods like mine (PlatformerSaves/PersistenceAPI) rely on the memory structure of these stl types and until robtop decides to update the ndk the game uses this is the next best thing I guess. Making it a draft PR cause there's a bunch of little hacks and just in general stuff I scrambled together to get it to compile at all, and I just tested for a bit that geode launched properly with this and played for a bit.