-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix distance field #145
base: master
Are you sure you want to change the base?
Conversation
) | ||
with_latlng | ||
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*") | ||
.order(Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [89/80]
Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc') | ||
) | ||
with_latlng | ||
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]
with_latlng | ||
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*") | ||
.where(bound_conditions(bounds)) | ||
.where(distance_conditions(options)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
|
||
with_latlng | ||
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*") | ||
.where(bound_conditions(bounds)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
distance_column_name = distance_sql(origin, units, formula) | ||
|
||
with_latlng | ||
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]
3dd5088
to
3f6bb58
Compare
No description provided.