Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix distance field #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bricesanchez
Copy link

No description provided.

)
with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.order(Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [89/80]

Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc')
)
with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.where(bound_conditions(bounds))
.where(distance_conditions(options))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.


with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.where(bound_conditions(bounds))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

distance_column_name = distance_sql(origin, units, formula)

with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants