Skip to content

[Backport 4.2.x] Editor / Keyword dropdown / Sort keywords by label - #8684

Open
geonetworkbuild wants to merge 2 commits into
4.2.xfrom
backport-8666-to-4.2.x
Open

[Backport 4.2.x] Editor / Keyword dropdown / Sort keywords by label#8684
geonetworkbuild wants to merge 2 commits into
4.2.xfrom
backport-8666-to-4.2.x

Conversation

@geonetworkbuild

Copy link
Copy Markdown
Collaborator

Backport #8666
Authored by: @joachimnielandt

joachimnielandt and others added 2 commits March 7, 2025 16:30
@sonarqubecloud

sonarqubecloud Bot commented Mar 7, 2025

Copy link
Copy Markdown

@josegar74 josegar74 added this to the 4.2.12 milestone Mar 12, 2025
@josegar74

Copy link
Copy Markdown
Member

@joachimnielandt I have tested with INSPIRE themes and Data themes (DCAT) vocabularies in Dutch and I get the terms sorted alphabetically without requiring this code. Do you have any vocabulary I can use to test?

@joachimnielandt

Copy link
Copy Markdown
Contributor

@joachimnielandt I have tested with INSPIRE themes and Data themes (DCAT) vocabularies in Dutch and I get the terms sorted alphabetically without requiring this code. Do you have any vocabulary I can use to test?

Hello @josegar74 , I needed this modification to sort the labels of the following thesaurus: https://vocab.belgif.be/auth/datatheme. This would be in the context of the VL fork (https://github.com/Informatievlaanderen/metadata-geonetwork), using the dcat-ap editor (https://github.com/metadata101/dcat-ap).

@josegar74

Copy link
Copy Markdown
Member

@joachimnielandt probably something specific about the DCAT-AP plugin, I tried 4.2.x without the pull request with your vocabulary and it seems sorted fine.

vocabulary

@joachimnielandt

Copy link
Copy Markdown
Contributor

With @fxprunayre I have retested a bit and we found that it's about the translated labels vs the default labels, both in ISO and in DCAT (probably due to KeywordsApi.java doing some sorting on defaultLabels). The following was tested on core-geonetwork develop vs 4.2.x, in an ISO record, for the GEMET thesaurus.

with the fix I proposed, both /dut/ and /eng/ UI will show a dropdown with sorted translated labels
image
image

without the fix: the dropdown is sorted for english labels, but not for translated labels
image
image

@josegar74 josegar74 modified the milestones: 4.2.12, 4.2.16 Jun 6, 2026
@juanluisrp juanluisrp modified the milestones: 4.2.16, 4.2.17 Jun 11, 2026
@josegar74 josegar74 modified the milestones: 4.2.17, 4.2.18 Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants