add datepicker with indeterminate position to iso19139 schema. fix datepicker. layout fix by davidblasby · Pull Request #9151 · geonetwork/core-geonetwork

davidblasby · 2026-01-29T23:30:57Z

This PR:

fix a UX issue with the datepicker. It resets the date/time when the indeterminateposition is now/unknown. However, the user could still change the date and time. When they save/reload, the time/date would be reset to blank - which is a bit confusing. The fix turns off the date/time control if the indeterminateposition is now/unknown.
Before, the extent was just a simple date picker (one field). If it was left blank, it would produce an indexing error. Now, the user can select a indeterminateposition as now (still being updated) or unknown (user doesn't know). This will set the indeterminatePosition flag on the element and there will not be an indexing error.

if the indeterminateposition is now/unknown, you cannot enter the date/time:

NOTE: this uses a template so it follows the same mechanism as in HNAP (see metadata101/iso19139.ca.HNAP#468)

Also, see HNAP PR: metadata101/iso19139.ca.HNAP#468

Checklist

josegar74

Please check the comments.

Also the section label is Extent, probably from the parent element. It would be better to check if possible to use Temporal extent .

It also handles gml:beginPosition, gml:endPosition. To check also to support the old namespace as in

core-geonetwork/schemas/iso19139/src/main/plugin/iso19139/layout/layout-custom-fields.xsl

Lines 161 to 162 in 5f6571e

    
                           match="gml:beginPosition|gml:endPosition|gml:timePosition| 
        
                                  gml320:beginPosition|gml320:endPosition|gml320:timePosition"

I think also gml:timePosition should be supported as supports indeterminatePosition. See https://www.datypic.com/sc/niem21/e-gml32_timePosition.html

<gmd:extent>
    <gml:TimePeriod gml:id="d57e396a1052958">
        <gml:relatedTime>
            <gml:TimeInstant gml:id="d1672e245a1052958">
                <gml:relatedTime>
                    <gml:TimePeriod gml:id="d1672e247a1052958">
                        <gml:begin>
                            <gml:TimeInstant gml:id="d1672e249a1052958">
                                <gml:timePosition/>
                            </gml:TimeInstant>
                        </gml:begin>
                        <gml:end>
                            <gml:TimeInstant gml:id="d1672e252a1052958">
                                <gml:timePosition/>
                            </gml:TimeInstant>
                        </gml:end>
                    </gml:TimePeriod>
                </gml:relatedTime>
                
            </gml:TimeInstant>
        </gml:relatedTime>        
    </gml:TimePeriod>
</gmd:extent>

josegar74 · 2026-01-31T10:29:52Z

+
+    <xsl:variable name="indeterminatePosition" select="@indeterminatePosition" />
+
+    <xsl:variable name="directiveAttributes">


This seems not used.

josegar74 · 2026-01-31T10:32:30Z

+    <xsl:variable name="value" select="normalize-space(text())"/>
+    <xsl:variable name="isoType" select="if (../@gco:isoType) then ../@gco:isoType else ''"/>
+    <xsl:variable name="labelConfig" select="gn-fn-metadata:getLabel($schema, name(), $labels, name(..), $isoType, $xpath)"/>
+    <xsl:variable name="attributes">


This seems not used

davidblasby · 2026-02-02T20:05:47Z

made minor change to the css there is a "temporal extent" tag:

Not perfect, but should be ok.

davidblasby · 2026-02-09T22:51:23Z

Localities in Victoria GML-32.xml
Localities in Victoria GML OLD.xml

^^ These are a test case for GML (old) and GML (3.2)

davidblasby · 2026-02-10T16:23:28Z

@josegar74 - when you look at this, please also press the "validate" button.

tylerjmchugh · 2026-02-18T14:04:29Z

I think this should be disabled too when the time and date are disabled:

tylerjmchugh · 2026-02-18T14:50:35Z

        class="form-control gn-time"
        data-ng-class="hideTime == 'true' ? 'hidden' : ''"
        data-ng-model="time"
        data-ng-show="mode === ''"


data-ng-show has conflicts with the new date only mode introduced in #9153

But once that is resolved both functionalities seem to work apart from some UI issues:

tylerjmchugh · 2026-02-18T15:01:21Z

The UI does not seem to match the rest of the form:

…tepicker. layout fix # Conflicts: # web-ui/src/main/resources/catalog/components/edit/datepicker/partials/datepicker.html

davidblasby · 2026-02-18T21:37:20Z

I think I've addressed tyler's feedback:

extent.mp4

@josegar74 - see tyler's images (above) and the last few seconds of the video. Perhaps you could (if needed) get the sections correct?

sonarqubecloud · 2026-02-18T21:37:42Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

josegar74 · 2026-02-24T15:08:46Z

 @import "gn_view.less";

+//ensure gn-beginPosition has the label displayed
+.gn-beginPosition {


Is this style used? I can't find it in the HTML of the metadata editor

yes - its automagically added.

Can you point where is added? I could not find it

you can see that the XSLT adds in gn-* classes.

josegar74 · 2026-02-24T15:12:30Z

+              var namespaceURI = gnSchemaManagerService.findNamespaceUri(
+                namespace,
+                gnCurrentEdit.schema
+              );
+              if (namespaceURI !== undefined) {
+                elementNSDef = " xmlns:" + namespace + '="' + namespaceURI + '"';
+              }


Would not be more efficient to put this code in the else of:

//if data-assume-gml-ns is set, then don't put in the NS declaration if (scope.assumeGmlNs === "true" && namespace === "gml") { elementNSDef = ""; }

I don't think efficiency is important here.

In that case is ok.

josegar74

@davidblasby an issue I found is that in the full view, it seems using the template also, so you can not really add a Time instant

davidblasby · 2026-02-24T16:00:19Z

@davidblasby an issue I found is that in the full view, it seems using the template also, so you can not really add a Time instant

ok, will wait for your feedback and take a look tomorrow or the next day.

josegar74 · 2026-02-27T12:47:39Z

+    This is basically a stand-in for the  <field name="temporalRangeSection"> and uses the same template to do the controls.
+  -->
+  <xsl:template mode="mode-iso19139"
+                match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[//gml:beginPosition]"


Suggested change

match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[//gml:beginPosition]"

match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[gmd:EX_TemporalExtent/gmd:extent/gml:TimePeriod//gml:beginPosition]"

@david-blasby this change target better the element and solves the problems with the full view. Please give a try and let me know.

I had some issues with the sample data, so I had to update this to:

match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[//local-name()='beginPosition']"

(i.e. handle multiple GML "versions" by using local-name instead of a prefixed name (ie. gml:beginPosition)).

@josegar74 - I'm not sure how that will work. Here is a typical beginPosition XML (from the GN sample data):

<gmd:extent> <gmd:EX_Extent> <gmd:temporalElement> <gmd:EX_TemporalExtent> <gmd:extent> <gml:TimePeriod xmlns:gml="http://www.opengis.net/gml/3.2" gml:id="d3773e252a1052958"> <gml:beginPosition indeterminatePosition="before">2000-01-01T04:29:00</gml:beginPosition> <gml:endPosition indeterminatePosition="after">2008-01-08T05:29:00</gml:endPosition> </gml:TimePeriod> </gmd:extent> </gmd:EX_TemporalExtent> </gmd:temporalElement> </gmd:EX_Extent> </gmd:extent>

I'm not sure how:

match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[gmd:EX_TemporalExtent/gmd:extent/gml:TimePeriod//gml:beginPosition]"

will match this. Perhaps I am unfamiliar where the "[" will occur. I I thought it would evaluate at the gmd:temporalElement location (i.e. requires gmd:temporalElement/gmd:EX_TemporalExtent/...).

@josegar74 - I've pushed another commit.

changes some of the XPATHs to local-name matching for the gml:/gml320: prefixes

added your match, above (converted to local-name matching)

I'm not sure how to test what you found (unable to add TimeInstant). I think (not sure) that its still problematic.

…r more exact matching

sonarqubecloud · 2026-03-27T19:32:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tylerjmchugh · 2026-04-14T18:39:09Z

I still see some issues with formatting in HNAP as well as iso19139:

Additionally I still seem to get the indexing error when end is set to "unknown" for example:

…_default.less

…o display the container and templates to remove empty sections

josegar74 · 2026-05-12T07:08:31Z

@tylerjmchugh please check latest changes to improve the rendering, thanks

tylerjmchugh

@josegar74 @davidblasby

I still see the same issues with HNAP:

Temporal Extent header is not in a collapsible section like it was before
Field length should match other fields
We should not see indexing errors when we use an unknown end date

Not sure if that is to be addressed here or in the HNAP PR. The changes seem ok in iso19139.

josegar74 · 2026-05-22T09:16:52Z

@tylerjmchugh

Using also metadata101/iso19139.ca.HNAP#468

I get the following rendering, which looks fine, and selecting the end date indeterminate position as Now the warning is not displayed, that seems correct according to https://github.com/metadata101/iso19139.ca.HNAP/blob/4f14270ad6aa56e5d16f8f3bed0e8e425303366c/src/main/plugin/iso19139.ca.HNAP/index-fields/index.xsl#L768-L769

With the value Unknown the validation reports the warning, but the index file doesn't check that value, maybe requires to be updated?

There some changes for iso19139 metadata schema files that need to be applied also in HNAP, I will check about that.

sonarqubecloud · 2026-05-27T09:04:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-08-12T06:34:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

josegar74 reviewed Jan 31, 2026

View reviewed changes

ianwallen added this to the 4.4.10 milestone Feb 18, 2026

tylerjmchugh reviewed Feb 18, 2026

View reviewed changes

david-blasby added 7 commits February 18, 2026 10:28

add datepicker with indeterminate position to iso19139 schema. fix da…

be90512

…tepicker. layout fix # Conflicts: # web-ui/src/main/resources/catalog/components/edit/datepicker/partials/datepicker.html

backout hnap submodule

29726d8

force PR to re-evaluate

e544915

remove hnap

fa6fb38

remove unused xslt vars, add label text back in

8638316

add for <begin|end> and handle gml OLD and gml 3.2

a243b37

layout changes, hide datapicker components when not needed

efd8b22

davidblasby force-pushed the _date_indeterminate branch from f33781f to efd8b22 Compare February 18, 2026 21:14

make indeterminate position dropdown larger

fd322b0

josegar74 reviewed Feb 24, 2026

View reviewed changes

josegar74 reviewed Feb 27, 2026

View reviewed changes

add better gml-version agnostic matching. Add suggestion from jose fo…

2ef8342

…r more exact matching

PascalLike requested review from josegar74 and tylerjmchugh April 9, 2026 15:57

josegar74 reviewed May 4, 2026

View reviewed changes

Comment thread schemas/iso19139/src/main/plugin/iso19139/layout/layout-custom-fields.xsl Outdated

josegar74 reviewed May 4, 2026

View reviewed changes

Comment thread web-ui/src/main/resources/catalog/views/default/less/gn_editor_default.less Outdated

Update web-ui/src/main/resources/catalog/views/default/less/gn_editor…

05befaf

…_default.less

Update rendering of temporal period for beginPosition / endPosition t…

144bace

…o display the container and templates to remove empty sections

josegar74 force-pushed the _date_indeterminate branch from 327d533 to 144bace Compare May 12, 2026 07:06

tylerjmchugh suggested changes May 20, 2026

View reviewed changes

Merge branch 'main' into _date_indeterminate

2d1af24

josegar74 modified the milestones: 4.4.10, 4.4.12 Jun 6, 2026

fxprunayre modified the milestones: 4.4.12, 4.4.13 Jul 8, 2026

josegar74 added 2 commits August 12, 2026 08:01

Merge branch 'main' into _date_indeterminate

e753a94

Update gml:TimePeriod template to preserve original namespace

4ee9328

	match="gml:beginPosition\|gml:endPosition\|gml:timePosition\|
	gml320:beginPosition\|gml320:endPosition\|gml320:timePosition"


		<xsl:variable name="indeterminatePosition" select="@indeterminatePosition" />

		<xsl:variable name="directiveAttributes">

	match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[//gml:beginPosition]"
	match="gmd:MD_Metadata/gmd:identificationInfo/gmd:MD_DataIdentification/gmd:extent/gmd:EX_Extent/gmd:temporalElement[gmd:EX_TemporalExtent/gmd:extent/gml:TimePeriod//gml:beginPosition]"

Uh oh!

Uh oh!

Conversation

davidblasby commented Jan 29, 2026

Checklist

Uh oh!

josegar74 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidblasby commented Feb 2, 2026

Uh oh!

davidblasby commented Feb 9, 2026

Uh oh!

davidblasby commented Feb 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidblasby commented Feb 18, 2026

Uh oh!

sonarqubecloud Bot commented Feb 18, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josegar74 left a comment

Choose a reason for hiding this comment

Uh oh!

davidblasby commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidblasby Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Mar 27, 2026

Quality Gate passed

Uh oh!

tylerjmchugh commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

josegar74 commented May 12, 2026

Uh oh!

tylerjmchugh left a comment

Choose a reason for hiding this comment

Uh oh!

josegar74 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 27, 2026

Quality Gate passed

Uh oh!

sonarqubecloud Bot commented Aug 12, 2026

josegar74 left a comment •

edited

Loading

davidblasby commented Feb 24, 2026 •

edited

Loading

davidblasby Mar 27, 2026 •

edited

Loading

josegar74 commented May 22, 2026 •

edited

Loading