[Backport 4.2.x] Map viewer / WFS filter / remove unused SLD API endpoints#9344
Merged
Conversation
Backport of cc96ed7 to 4.2.x. The generateSLD, getSLD, buildSLD, updateSLD and deleteSLD endpoints in SldApi were never called from the frontend. Remove them along with the TextFile JPA entity and repository that backed the SLD storage. Simplify the WFS filter service to always use the WMS FILTER parameter instead of SLD/SLD_BODY. The /filter endpoint (POST) is kept as the only remaining endpoint in SldApi. Add a DB migration to drop the now-unused files table and sequence.
juanluisrp
changed the title
- Add file headers and minor code improvements. - Add unit tests for SLDUtil
josegar74
force-pushed
the
backport-test-4.2.x
branch
from
5d0206b to
cdc02d6
Compare
josegar74
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9343 to the 4.2.x branch.
Summary
generateSLD,getSLD,buildSLD,updateSLD,deleteSLD) fromSldApi; keep onlyPOST /filterTextFileJPA entity andTextFileRepository(backed the now-removed SLD storage)config-security-mapping.xmlFILTERparameter instead of SLD/SLD_BODYfilestable and sequenceConflict resolution vs main
SldApi.java: usesorg.opengis.filter.Filter(4.2.x GeoTools API) instead oforg.geotools.api.filter.Filterconfig-security-mapping.xml: preserves the Datahub entries present only in 4.2.xSLDUtilTest.java: deleted (tests covered removed methods)v4217/instead ofv4412/Test plan
FILTERparam is set on the WMS request and no SLD/SLD_BODY param is present)POST /{portal}/api/tools/ogc/filterreturns 201 with OGC XMLfilestable on a fresh upgrade