Skip to content

Make validation and publication options usable without the metadata approval workflow #9420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josegar74 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make validation and publication options usable without the metadata approval workflow #9420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5320ef2
Make validation and publication options usable without the metadata a…
josegar74 Jul 15, 2026
e851290
Make validation and publication options usable without the metadata a…
josegar74 Jul 16, 2026
ca27dbd
Merge branch 'main' into metadata-validation-settings-refactor
josegar74 Jul 17, 2026
78fb36e
Merge remote-tracking branch 'upstream/main' into metadata-validation…
josegar74 Jul 23, 2026
d68d9a6
Merge remote-tracking branch 'upstream/main' into metadata-validation…
josegar74 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/fao/geonet/kernel/metadata/MetadataPublicationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ public void setOperations(

boolean sharingChanges = false;

boolean allowPublishInvalidMd = sm.getValueAsBool(Settings.METADATA_WORKFLOW_ALLOW_PUBLISH_INVALID_MD);
boolean allowPublishInvalidMd = sm.getValueAsBool(Settings.METADATA_PUBLICATION_ALLOW_PUBLISH_INVALID_MD);
boolean allowPublishNonApprovedMd = sm.getValueAsBool(Settings.METADATA_WORKFLOW_ALLOW_PUBLISH_NON_APPROVED_MD);

boolean isMdWorkflowEnable = sm.getValueAsBool(Settings.METADATA_WORKFLOW_ENABLE);
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/java/org/fao/geonet/kernel/setting/Settings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ public class Settings {
public static final String METADATA_WORKFLOW_ENABLE = "metadata/workflow/enable";
public static final String METADATA_WORKFLOW_DRAFT_WHEN_IN_GROUP = "metadata/workflow/draftWhenInGroup";
public static final String METADATA_WORKFLOW_ALLOW_SUBMIT_APPROVE_INVALID_MD = "metadata/workflow/allowSubmitApproveInvalidMd";
public static final String METADATA_WORKFLOW_ALLOW_PUBLISH_INVALID_MD = "metadata/workflow/allowPublishInvalidMd";
public static final String METADATA_PUBLICATION_ALLOW_PUBLISH_INVALID_MD = "metadata/publication/allowPublishInvalidMd";
public static final String METADATA_WORKFLOW_ALLOW_PUBLISH_NON_APPROVED_MD = "metadata/workflow/allowPublishNonApprovedMd";
public static final String METADATA_WORKFLOW_AUTOMATIC_UNPUBLISH_INVALID_MD = "metadata/workflow/automaticUnpublishInvalidMd";
public static final String METADATA_WORKFLOW_FORCE_VALIDATION_ON_MD_SAVE = "metadata/workflow/forceValidationOnMdSave";
public static final String METADATA_PUBLICATION_AUTOMATIC_UNPUBLISH_INVALID_MD = "metadata/publication/automaticUnpublishInvalidMd";
public static final String METADATA_SAVE_FORCE_VALIDATION_ON_MD_SAVE = "metadata/save/forceValidationOnMdSave";
public static final String METADATA_LINK_EXCLUDEPATTERN = "metadata/link/excludedUrlPattern";
public static final String METADATA_IMPORT_RESTRICT = "metadata/import/restrict";
public static final String METADATA_IMPORT_USERPROFILE = "metadata/import/userprofile";
Expand Down
25 changes: 23 additions & 2 deletions ...manual/docs/administrator-guide/configuring-the-catalog/system-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,17 +376,38 @@ Allows to configure the user profile allowed to delete published metadata.

![](img/metadata-delete.png)

## Metadata workflow

Allows to configure the metadata approval workflow (record life cycle). See [Life cycle](../../user-guide/workflow/life-cycle.md) for details about how the workflow is used.

- **Enable workflow** Enables the metadata approval workflow. When enabled, editors work on a draft copy of approved records and changes must be submitted and approved before they become visible to users outside the owner group. The default value is disabled.
- **Activate workflow for record created in** Restricts the groups for which the workflow is automatically activated when a record is created. Choose `Any group` to activate it for all groups, or `Selected groups` to provide a regular expression matching the group names where records must be set to draft status automatically. eg. `MYOCEAN-.*` to match all groups starting with `MYOCEAN-`, `GROUP1|GROUP2` to match `GROUP1` or `GROUP2`.
- **Allow submission/approval of invalid metadata** Allows the submission/approval of metadata that is not valid according to xsd or schematron rules. The default value is enabled.

@sebr72 sebr72 Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know it is invalid, it seems strange to allow its approval by default. Don't you think ? (maybe we should clarify why, at the very least in the readme)

- **Allow publication of non-approved metadata** Allows the publication of metadata that is not approved. The default value is enabled.

@sebr72 sebr72 Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.


## Metadata publication

Allows to configure the required user profile to publish and un-publish metadata.
Allows to configure the publication of metadata records.

The settings in this section apply whether or not the metadata approval workflow is enabled.

The configured profile is evaluated on the metadata owner group (per-group role), not the user's global profile. The user must have exactly this profile in the record owner group. For example, with `Reviewer`, only users who are `Reviewer` in the owner group are allowed (not `UserAdmin`). Global `Administrator` is always allowed.
The required user profile is evaluated on the metadata owner group (per-group role), not the user's global profile. The user must have exactly this profile in the record owner group. For example, with `Reviewer`, only users who are `Reviewer` in the owner group are allowed (not `UserAdmin`). Global `Administrator` is always allowed.

- **Required profile to publish metadata** Profile required to publish metadata, evaluated in the record owner group (`Reviewer` or `Administrator`). The default value is `Reviewer`.
- **Required profile to un-publish metadata** Profile required to un-publish metadata, evaluated in the record owner group (`Reviewer` or `Administrator`). The default value is `Reviewer`.
- **Allow publication of invalid metadata** Allows the publication of metadata that is not valid according to xsd or schematron rules. When disabled, a record that is invalid cannot be published to the `All` group. The default value is enabled.
- **Automatic unpublication of invalid metadata** Automatically unpublishes metadata that, once edited, becomes not valid according to xsd or schematron rules. The default value is disabled.

![](img/metadata-publication.png)

## Metadata save

Allows to configure the behaviour when a metadata record is saved and the editor is closed.

This setting applies whether or not the metadata approval workflow is enabled.

- **Force validation on metadata save** When enabled, the validation of the metadata is forced (and its validation status stored) each time the record is saved and the editor is closed. The default value is disabled.

## Metadata selection - zip export

Allows to configure the zip export of metadata records and their attachments.
Expand Down
8 changes: 5 additions & 3 deletions schemas/iso19115-3.2018/src/test/resources/UpperRhineCastles-ISO19115-3-full-view-form.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,6 +2175,8 @@
<tocPage name="metadata/pdfReport/tocPage" position="12502" datatype="2" datatypeName="BOOLEAN">false</tocPage>
</pdfReport>
<publication name="metadata/publication" position="12021">
<allowPublishInvalidMd name="metadata/publication/allowPublishInvalidMd" position="100006" datatype="2" datatypeName="BOOLEAN">true</allowPublishInvalidMd>
<automaticUnpublishInvalidMd name="metadata/publication/automaticUnpublishInvalidMd" position="100007" datatype="2" datatypeName="BOOLEAN">false</automaticUnpublishInvalidMd>
<profilePublishMetadata name="metadata/publication/profilePublishMetadata" position="12021" datatype="0" datatypeName="STRING">Reviewer</profilePublishMetadata>
<profileUnpublishMetadata name="metadata/publication/profileUnpublishMetadata" position="12022" datatype="0" datatypeName="STRING">Reviewer</profileUnpublishMetadata>
</publication>
Expand All @@ -2188,14 +2190,14 @@
<enable name="metadata/vcs/enable" position="9161" datatype="2" datatypeName="BOOLEAN">false</enable>
</vcs>
<workflow name="metadata/workflow" position="100006">
<allowPublishInvalidMd name="metadata/workflow/allowPublishInvalidMd" position="100006" datatype="2" datatypeName="BOOLEAN">true</allowPublishInvalidMd>
<allowPublishNonApprovedMd name="metadata/workflow/allowPublishNonApprovedMd" position="100005" datatype="2" datatypeName="BOOLEAN">true</allowPublishNonApprovedMd>
<allowSubmitApproveInvalidMd name="metadata/workflow/allowSubmitApproveInvalidMd" position="100004" datatype="2" datatypeName="BOOLEAN">true</allowSubmitApproveInvalidMd>
<automaticUnpublishInvalidMd name="metadata/workflow/automaticUnpublishInvalidMd" position="100007" datatype="2" datatypeName="BOOLEAN">false</automaticUnpublishInvalidMd>
<draftWhenInGroup name="metadata/workflow/draftWhenInGroup" position="100003" datatype="0" datatypeName="STRING" />
<enable name="metadata/workflow/enable" position="100002" datatype="2" datatypeName="BOOLEAN">false</enable>
<forceValidationOnMdSave name="metadata/workflow/forceValidationOnMdSave" position="100008" datatype="2" datatypeName="BOOLEAN">false</forceValidationOnMdSave>
</workflow>
<save name="metadata/save" position="100008">
<forceValidationOnMdSave name="metadata/save/forceValidationOnMdSave" position="100008" datatype="2" datatypeName="BOOLEAN">false</forceValidationOnMdSave>
</save>
</metadata>
<region name="region" position="9590">
<getmap name="region/getmap" position="9590">
Expand Down
Loading
Loading