Record page / Fix wrong display of parent metadata link for series metadata - #9468
Open
josegar74 wants to merge 1 commit into
Open
Record page / Fix wrong display of parent metadata link for series metadata#9468josegar74 wants to merge 1 commit into
josegar74 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Test case
With the fix it shows up properly:
Root cause
Two unrelated LESS rules both nested under .gn-md-view were targeting the same generic
.galleryclass:.gn-md-view.gallery — meant to float the series/service thumbnail mosaic (data-gn-record-mosaic, shown above the "Member of" link) atwidth: 33%; height: 300px; float: right..gn-md-view .gn-card .gallery— meant for a different gallery (search-result card thumbnails), settingwidth: 100%; height: auto.Because the record-view page wraps the title block in
.gn-card, the 3-class selector beat the 2-class one on width/height, but not on float (which it never set). The mosaic ended upfloat: rightandwidth: 100%withheight: auto.When the mosaic had no images (as in the Ice series 2 series record), it collapsed to a full-width, zero-height float sitting right where the "Member of" link text starts — leaving 0px on that first line, so "Ice" broke after "I" and the rest wrapped to the next line. This only happens for
series/servicerecords, since the mosaic markup is only rendered for those resource types — matching exactly why the dataset page never showed the bug.Fix:
gn-record-mosaicclass alongside gallery..gn-md-view .gn-record-mosaic..gallery:not(.gn-record-mosaic).This decouples the two independent "gallery" use cases so neither can leak into the other; the search-result card gallery is untouched, and the record-view mosaic keeps its intended float layout, which no longer squeezes the adjacent link text.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation