Fix attachments endpoint - #9473
Open
tylerjmchugh wants to merge 2 commits into
Open
Conversation
tylerjmchugh
force-pushed
the
fix-attachments-endpoint
branch
from
August 12, 2026 14:52
b4f1769 to
cda23e2
Compare
tylerjmchugh
marked this pull request as ready for review
August 12, 2026 15:18
Member
|
@tylerjmchugh changes look fine, can you check this updated test file and include the changes? |
Contributor
Author
Thank you. Updated the test in the latest push. |
josegar74
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9443 introduced a new method
approvedCopyExiststo check if the requested version exists. The logic seems to have a bug though as it first checks the working copy repository. So if there is a working copyapprovedCopyExistsalways returns false even if there is an approved copy as well.This PR aims to fix this issue by instead checking the regular metadata repository first as this is where the approved copy would be.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation