Repository navigation
Reject boolean values for the limit parameter - #2419
Shubham-Padkonde wants to merge 2 commits into
Conversation
get_typed_value turns limit=true into the boolean True, which passed the isinstance(..., int) check because bool is a subclass of int, so evaluate_limit returned True as the limit (and limit=false failed with "should be strictly positive"). Booleans are now rejected with the same "should be an integer" error as other non-integer values.
|
The current Build failure is in PostgreSQL provider setup: all 42 failed cases in #2419 and #2420 raise Logs: https://github.com/geopython/pygeoapi/actions/runs/36156172783 and https://github.com/geopython/pygeoapi/actions/runs/36156196416. Would you prefer the shared fixture to specify Update, November 5: upstream pinned SQLAlchemy to 2.0.54 in 70bf214. Both branches now include that pin. The provider suite that had 42 failures passed all 424 tests on #2419 and #2420. That resolves the driver question above for these PRs. |
get_typed_value turns limit=true into the boolean True, which passed the isinstance(..., int) check because bool is a subclass of int, so evaluate_limit returned True as the limit (and limit=false failed with "should be strictly positive"). Booleans are now rejected with the same "should be an integer" error as other non-integer values.
Overview
Related Issue / discussion
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)