Skip to content

Fix ogr source feature serialization performance issues - #2474

Open
reinvantveer wants to merge 1 commit into
geopython:masterfrom
SPOTinfo:fix-ogr-feature-serialization-perf
Open

reinvantveer wants to merge 1 commit into
geopython:masterfrom
SPOTinfo:fix-ogr-feature-serialization-perf

Conversation

@reinvantveer

@reinvantveer reinvantveer commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Related Issue / discussion

Resolves #2473

AI disclosure: although Claude Opus 5.5 greatly helped in determining the cause of and writing the fix for, this performance bug, I checked every step to validate parity and that it is a "pure refactor". The commits are signed by me (@reinvantveer) and co-authored by the JetBrains Junie agent.

I'm fully on board with the BHFH statement, but I'll be honest and state that I wouldn't have been able to contribute this PR if it hadn't been for AI. I did, however, ask explicitly for adding parity checks that verify that the output of the refactored code is unchanged.

NOTE that this fix is already running in production on our platform, and that I'm very happy with the results 😄

NOTE2 the failing test steps are not related to changes in this PR. These failures originate in the zarr and xarray dependency versions.

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute this bugfix to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Co-authored-by: Junie <junie@jetbrains.com>
Signed-off-by: reinvantveer <rein@vantveer.me>
@github-actions github-actions Bot added the AI generated Label for the detect-ai workflow classifier label Oct 28, 2026
@doublebyte1

Copy link
Copy Markdown
Contributor

@reinvantveer Thank you for your honest disclosure!

@reinvantveer

Copy link
Copy Markdown
Contributor Author

@tomkralidis would you be OK to look into this? Or is there something inhibiting a merge of this PR in any way?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI generated Label for the detect-ai workflow classifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issues affecting wide table sources

2 participants