Adding support for MariaDb as backend for EvaDB #1027
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @jineetd, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
|
Thanks for the contribution jineetd! Could you add the following as described in https://evadb.readthedocs.io/en/stable/source/dev-guide/extend/new-data-source.html?
|
xzdandy
added
Integrations 🧩
|
|
||
| try: | ||
| query = f"SELECT column_name as 'name', data_type as 'dtype' FROM information_schema.columns WHERE table_name='{table_name}'" | ||
| columns_df = pd.read_sql_query(query, self.connection) |
There was a problem hiding this comment.
Can you also try running integrations locally? You probably miss a type mapping function https://github.com/georgia-tech-db/evadb/blob/c9ae49890d83bbfdaefcf6cbb54a0e2347dfeb66/evadb/third_party/databases/postgres/postgres_handler.py#L108C13-L108C86.
There was a problem hiding this comment.
Added the mapping function
There was a problem hiding this comment.
Thanks. Just double-check, does your integration pass when you run locally?
|
|
||
| try: | ||
| query = f"SELECT column_name as 'name', data_type as 'dtype' FROM information_schema.columns WHERE table_name='{table_name}'" | ||
| columns_df = pd.read_sql_query(query, self.connection) |
There was a problem hiding this comment.
Thanks. Just double-check, does your integration pass when you run locally?
No description provided.