Open
Conversation
kottmanj
reviewed
Dec 17, 2020
kottmanj
reviewed
Dec 17, 2020
kottmanj
reviewed
Dec 17, 2020
| elif gate.name == 'X': | ||
| ### off by global phase of Exp[ pi power /2] | ||
| ''' | ||
| if we wanted to do it formally we would use the following |
There was a problem hiding this comment.
Nice. Very clear. Global phase is fine. Maybe add "Global phases can be ignored. For controlled gates the global phase becomes a relative phase so this structure is respected in the compilation of controlled gates." or something like this
|
Fantastic! |
…Calculus operations ajustes Validate import pyzx and validate multiple targets and max 2 controls compile_ry() consider all targets, and small fix name improve compile_y() method Add flag for zx-calculus and break down controlled rotations not supported by qasm set default value Tests for compile_ry and compile_y Convinient unitary gates: U, u1, u2, u3 and its tests Import QASM code logic, including custom gates Pyzx doesn't understand controlled-H, so a compile option is added to support CH for pyzx
…for u1,u2,u3 gates
georgios-ts
pushed a commit
that referenced
this pull request
Feb 10, 2021
refactor Compiler (Georgios)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger Github actions.