Add customizable GeodesicMeasure #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/customizable-geodesic
branch
2 times, most recently
from
8358da0 to
d952d7e
Compare
urschrei
approved these changes
Feb 14, 2025
| /// Distances are computed using [geodesic lines] and are measured **in meters**. | ||
| /// | ||
| /// [`GeodesicMeasure`] allows creating a geodesic model with custom values for the equatorial | ||
| /// radius (`A`) and the inverse flattening factor (`F`). Unless you have special needs, just use |
There was a problem hiding this comment.
The most minor of nits: we should try not to use "just" in our public docs IMO, as it assumes a degree of knowledge / familiarity that the reader may not have (we are actually very good about this, barring some instances floating around in Haversine examples)
There was a problem hiding this comment.
This is a good nit. "just" is something I'm largely trying to strike from my writing. It usually doesn't add anything, is sometimes ambiguous, and sometimes condescending.
I've removed a few other instances in 1d9005e
Note: this bumps MSRV to 1.80 (released 6+ months ago) in order to
utilize `LazyLock`.
Perf: No measurable difference in the benchmarks
geodesic distance f64 time: [421.15 ns 423.53 ns 426.07 ns]
change: [-1.7862% -1.2409% -0.7204%] (p = 0.00 < 0.05)
Change within noise threshold.
…mes adds ambiguity.
michaelkirk
force-pushed
the
mkirk/customizable-geodesic
branch
from
d952d7e to
1d9005e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Building on #1298, adds the ability to customize your geoid for Karney geodesic calculations.
Note: this bumps MSRV to 1.80 (released 6+ months ago) in order to utilize
LazyLock.Perf: No measurable difference in the benchmarks