Fix incorrect open linestring distance computation#1499
Merged
michaelkirk merged 2 commits intogeorust:mainfrom Feb 4, 2026
Merged
Fix incorrect open linestring distance computation#1499michaelkirk merged 2 commits intogeorust:mainfrom
michaelkirk merged 2 commits intogeorust:mainfrom
Conversation
urschrei
approved these changes
Feb 4, 2026
Member
|
Oof, thanks for catching this. Mea culpa. |
michaelkirk
requested changes
Feb 4, 2026
Member
michaelkirk
left a comment
michaelkirk
left a comment
There was a problem hiding this comment.
Thank you finding and fixing this bug! Your code changes make sense, but I'm confused by the test case.
michaelkirk
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.The Euclidean distance computation method for linestrings produce incorrect results for disjoint, non-closed linestrings. This is because of a bug in the fast path for computing distances where the bboxes of linestrings are disjoint. We always drop the last coordinate when computing the projected coordinate, this will miss the end point when the projected linestring is not closed. This patch fixes the problem by only dropping the last coordinate for closed linestrings.
This problem was originally found when upgrading geo from 0.31.0 to 0.32.0 in apache/sedona-db#566.