#10901: Update plugin documentation of BrandNavbar and localConfig #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
added
bug
BackportNeeded
1 task
allyoucanmap
requested changes
Mar 7, 2025
Comment on lines
-415
to
-420
| { | ||
| "name": "BrandNavbar", | ||
| "cfg": { | ||
| "containerPosition": "header" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Why are we removing BrandNavbar from configuration?
The default application should keep the plugin while in the datadir we should just add the override for the specific cfg to override the logo
There was a problem hiding this comment.
The plugin rests in an array block ex: desktop, if we need to override we need to ensure there are in a fixed index position to apply an override. So if it's position accidentally modified we will lose the override and end up modifying a incorrect plugin in the position. To avoid it, I removed it from localConfig and prepended them in the patch file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates localConfig to remove BrandNavbar config and added to mapstore-datadir in this PR to include config and update plugin configuration
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Configuration will add logo and hyperlink from datadir to point to configured link
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information