Repository navigation
Conversation
Contributor
|
Thanks @shemerey for the PR. This repo approves new contributors before it reviews their PRs, so this PR now closes on its own. That is expected. Join the #contributors channel in Discord (https://discord.gg/kvBU6tJhcJ), post a link to this PR, and explain what it changes and why. A maintainer then adds you to the allow list and can reopen the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Embedded
ThreadChatcould add message actions but could not receive selected text or add an instance-scoped native selection action. Global message-action slots target the main timeline. It also could not omit the environment/access footer while retaining the native composer. This blocks LingQ's hidden tutor integration (companion PR).What changed
Summary
Both props are per instance and default behavior is unchanged. User prose opts into native selection only when requested, preserving ordinary user-copy behavior. Repeated words retain the selected occurrence. SDK declarations, runtime forwarding, testing harness, Plugin Guide inventory and API audit entry are included. No private imports, global action registration or CSS concealment. No server/daemon wire, persisted settings or permission-policy change; existing CLI/SDK send, queue and permission inspection paths still apply.
How you verified
Evidence
pnpm exec turbo run typecheck lint build --filter=@bb/app: passes. Lint reports 250 warnings, zero errors.pnpm exec turbo run test typecheck --filter=@get-bb/plugin-sdk: 372 passed. Plugin Guide: 72 passed. Formatting andgit diff --checkpass.npm run verify: 1,170 passed, 2 pre-existing manual skips; thresholds/excludes unchanged. Coverage 93.80% statements / 84.96% branches / 92.71% functions / 95.21% lines.permissionMode: auto, matching the resolved default with the footer absent.browserCLI family; no broad inventory rewrite was included.Contributor gate status
The repository's contributor gate automatically closed this PR because
shemereyis not allowlisted. Its bot comment requests maintainer contributor approval before reopening. The complete implementation remains on the fork branch; no allowlist changes or gate bypass are included.Merge Danger
Door: two-way
Blast Radius: UI
Additive experimental SDK props only; no permission widening or migrations. Ordinary timelines keep their defaults and existing action path. The consumer plugin PR remains draft with an explicitly local source-SDK dependency until these APIs are published; that dependency is not release-ready.