run onComplete inline always

[ianmacartney]

Instead of doing inline/inline -> schedule/schedule, let's do inline/inline -> schedule/inline, always running the onComplete handler inline in complete.ts so that the scheduler doesn't balloon with OCC-ing / retrying onComplete handlers while the workpool charges ahead.

Also write failed onComplete handlers for investigation / recovery purposes - though it'll be missing the full return value for now.

For un-catchable errors (e.g. the onComplete reads too much data) I think it would still wedge the workpool - but that's pre-existing and a bit orthogonal here

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5b53f86f-885a-4ef9-ab88-e1b8c2926252

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ianmacartney/oncomplete-transactional

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ianmacartney]

• run onComplete inline always #190 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/workpool/@convex-dev/workpool@190

commit: 4e922a7

[reeceyang]

this looks good!

[reeceyang]

I wonder if we should save the scheduled job id somewhere so that recovery can look it up if complete failed for an un-catchable reason (e.g. too many reads).