fix(install): strip macOS quarantine in the curl installer#177
Merged
Conversation
Gatekeeper blocks our unsigned/un-notarized binaries with "Apple could not verify 'deacon' is free of malware" when they arrive via a quarantining download path (browser/Finder). The installer now removes the com.apple.quarantine attribute after placing the binary on macOS. curl/wget downloads aren't quarantined, so for a piped install this is typically a no-op — it's belt-and-suspenders and double-guarded (macOS only, and only when `xattr` is available), so Linux/Windows installs are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mac users who install a release see: "Apple could not verify 'deacon' is free of malware that may harm your Mac or compromise your privacy." Our release binaries are unsigned/un-notarized, so macOS Gatekeeper blocks them whenever they carry the
com.apple.quarantineattribute (set by browser/Finder downloads).Fix (curl-installer side)
install.shnow removescom.apple.quarantinefrom the installed binary on macOS (afterchmod +x).curl/wgetdownloads are not quarantined, so for the pipedcurl … | bashflow this is usually a no-op — it's belt-and-suspenders that also covers binaries that arrived via a quarantining path.os == macosandxattrexists, so Linux/Windows installs are unaffected.deploy-pagesjob copiesscripts/install.shverbatim, so this ships with the next release.Validated with
bash -n. Function is a no-op on this Linux box (noxattr).Not included (follow-ups, by design)
enablement:truefix is onmainbut no release has run since).xattr -d com.apple.quarantine ./deaconone-liner to the release-notes "Install" section / README for manual-download users.🤖 Generated with Claude Code