Skip to content

feat: support multiple relays #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: support multiple relays #486

wants to merge 9 commits into from

Conversation

@rolznz
Copy link
Contributor

@rolznz rolznz commented Oct 5, 2025 •
edited
Loading

TODOs:

  • review client-created secret code (Nostr) and make sure it's still compatible/working
  • review client-created secret code (HTTP) and make sure it's still compatible/working
  • thorough testing with Alby Hub feat: support multiple relays hub#1802
  • testing:
    • subscribeNotifications: reconnection after relay closed and re-opened NOTE: individual relays sadly won't be reconnected until all relays close, and then they will be reconnected again
    • standard requests before/during/after relay reconnection
    • still works well with single relay / published version of Alby Hub
    • when multiple relays are online that events are deduplicated
    • 1-click flow (http) correctly uses multiple relays
    • 1-click flow (nostr) correctly uses multiple relays
    • notifications are not duplicated
    • command responses are not duplicated

Notes:

  • For the client-created secret flow it's unclear if we can have multiple recommended relays. So for now multiple relays are just passed to a new NWAClient and when the subscribe function returns we use those same relays.

@rolznz rolznz changed the title feat: support multiple relays (WIP) feat: support multiple relays Oct 28, 2025
@rolznz rolznz marked this pull request as ready for review October 28, 2025 16:44
@rolznz rolznz requested review from frnandu and im-adithya October 28, 2025 16:44
@rolznz rolznz mentioned this pull request Oct 28, 2025
Open
25 tasks
rolznz
rolznz commented Oct 28, 2025
View reviewed changes
src/nwc/NWCClient.ts
this.relay = new Relay(this.relayUrl);
this.relayUrls = this.options.relayUrls;
this.pool = new SimplePool({
// TODO: enableReconnect: true, once nostr-tools is updated
Copy link
Contributor Author

@rolznz rolznz Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: enableReconnect: true, once nostr-tools is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@im-adithya im-adithya Awaiting requested review from im-adithya

@frnandu frnandu Awaiting requested review from frnandu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rolznz