fix: make the necessary changes as per review

getAlby · Sep 18, 2023 · 12ed403 · 12ed403
1 parent e61cf7c
commit 12ed403
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 12 deletions.
diff --git a/src/app/components/AccountMenu/index.tsx b/src/app/components/AccountMenu/index.tsx
@@ -62,7 +62,7 @@ function AccountMenu({ showOptions = true }: Props) {
       <Menu as="div">
         <Menu.Button
           className="h-full px-2 rounded-md hover:bg-gray-100 dark:hover:bg-white/10 transition-colors duration-200"
-          aria-label={`Account menu`}
+          aria-label="Account Menu"
         >
           <div className="flex items-center">
             {accountLoading ? (

diff --git a/src/app/components/Button/index.tsx b/src/app/components/Button/index.tsx
@@ -66,7 +66,6 @@ const Button = forwardRef(
         )}
         onClick={onClick}
         disabled={disabled}
-        aria-label={label}
       >
         {loading && (
           <div className={direction === "row" ? "mr-2" : ""}>

diff --git a/src/app/components/Hyperlink/index.tsx b/src/app/components/Hyperlink/index.tsx
@@ -26,13 +26,12 @@ export default function Hyperlink({
       )}
       href={href}
       onClick={onClick}
-      onKeyDown={(e) => {
+      onKeyUp={(e) => {
         if (e.key === "Enter" && onClick) onClick();
       }}
       target={target}
       rel={rel}
       tabIndex={0}
-      aria-label={children?.toString()}
     >
       {children}
     </a>

diff --git a/src/app/components/PaymentSummary/index.tsx b/src/app/components/PaymentSummary/index.tsx
@@ -22,7 +22,7 @@ const PaymentSummary: FC<Props> = ({
     <dl
       className="mb-0"
       tabIndex={0}
-      aria-label={`Amount - ${getFormattedSats(amount)}, ~${fiatAmount}`}
+      aria-label={`Amount: ${getFormattedSats(amount)}, ~${fiatAmount}`}
     >
       <dt className="text-sm text-gray-500 dark:text-neutral-500">
         {tCommon("amount")}

diff --git a/src/app/components/ResultCard/index.tsx b/src/app/components/ResultCard/index.tsx
@@ -8,7 +8,6 @@ export default function ResultCard({ message, isSuccess }: Props) {
     <div
       className="p-12 font-medium drop-shadow rounded-lg mt-4 flex flex-col items-center bg-white dark:bg-surface-02dp"
       tabIndex={0}
-      aria-label={message}
     >
       <img
         src={isSuccess ? "assets/icons/tick.svg" : "assets/icons/cross.svg"}

diff --git a/src/app/components/TransactionsTable/index.tsx b/src/app/components/TransactionsTable/index.tsx
@@ -27,11 +27,7 @@ export default function TransactionsTable({
       <Loading />
     </div>
   ) : !transactions?.length && noResultMsg ? (
-    <p
-      className="text-gray-500 dark:text-neutral-400"
-      tabIndex={0}
-      aria-label={noResultMsg}
-    >
+    <p className="text-gray-500 dark:text-neutral-400" tabIndex={0}>
       {noResultMsg}
     </p>
   ) : (

diff --git a/src/app/screens/Home/DefaultView/index.tsx b/src/app/screens/Home/DefaultView/index.tsx
@@ -190,7 +190,6 @@ const DefaultView: FC<Props> = (props) => {
             <h2
               className="mb-2 text-lg lg:text-xl text-gray-900 font-bold dark:text-white"
               tabIndex={0}
-              aria-label={t("default_view.recent_transactions")}
             >
               {t("default_view.recent_transactions")}
             </h2>