-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker + docker-compose #844
Conversation
You can run project first Install docker then install docker-compose
To connect to container
If you need a Windows or Mac user I would recomend to try Beta Docker |
I would love to test this out, but alas, when i Try the new Beta Docker app, i get a nasty message about my 2008 Mac Pro being too old and not supported! Boo!!! I think it's time I get a new mac! Roll on WWDC! |
Naming
docker/Dockerfile
Outdated
|
||
COPY xdebug.ini /usr/local/etc/php/conf.d/xdebug.conf | ||
COPY php.ini /usr/local/etc/php/php.ini | ||
COPY vhost.conf /etc/apache2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file (vhost.conf) looks like an nginx config file, am I missing something ?
docker/Dockerfile
Outdated
RUN a2enmod ssl | ||
|
||
# https://github.com/sameersbn/docker-gitlab/issues/396 | ||
RUN sed -i 's/host = uri.host/host = "http:\/\/rubygems.org"/g' /usr/lib/ruby/2.1.0/rubygems/remote_fetcher.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
docker/Dockerfile
Outdated
libnotify-bin \ | ||
sudo | ||
|
||
RUN docker-php-ext-install mbstring pdo_mysql zip gd curl intl mcrypt soap opcache json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included the following line before:
RUN docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/
Otherwise JPEG images were not processed.
While we like the idea of a built-in docker config, a couple of things come to mind.
Some help with achieving these goals would be most welcome :) |
I will check |
Any Updates on this? Would love to see an official automated Dockerfile for grav! @rhukster I think the best way would be to just have an dockerfile in the project and setup an automated Dockerhub build that just builds a new Image on every push to the repo? |
Give me one more week I can't find time for this right now |
Sure. Hit me up if you need some help. |
Ok, lets test the docker as is for now and then if it runs ok move it to docker HUB. |
# Conflicts: # docker-compose.yml # docker/Dockerfile # docker/php.ini
@np I've developed a grav image which I suggested to be added to the docker official images, they have no objections adding grav, but want upstream to take part of it |
# Conflicts: # user/config/system.yaml
Update please. |
update please. It is 2018 we want docker ;P |
Hi guys, Just passing by to check if there's a will to provide an official Grav Docker image. Cheers. -j |
when i get back from vacation, i'll take a look at this properly. |
@Jucgshu I haven't seen an official (@rhukster would know) but I have been using https://github.com/ericpoe/docker-grav-fpm locally only though. would be amazing to have one I can deploy as well :) |
Fantastic news @rhukster -j |
Hate to be that guy, (but). If you need beta testers, just ask. -j |
hi there, it's still a WIP , i'm working on having a smaller and faster image using php built-in server, which seems to be suitable for a simple usage. cc @rhukster feel free to either rob some of the work i've done or suggest some tweaking on mine :) let me know what works best for you |
Ok, guys. I've started on this.. My aim is to have something as optimized as possible with only what is required in the 'official' docker image. Now i'm pretty new to Docker, so i'm having to learn this as I go along. I know you guys have more experience, so i'm going to be looking for help with this: https://github.com/getgrav/docker-grav Right now i JUST have a simple Please see this issue for a list of things that still need to be done. I think we can use some of the contributions in this repo, as well as other official images like Drupal/Wordpress/Joomla etc to get some ideas of what an Official should and shouldn't have in them. |
Let me help you on this then :) On my way to the repo |
I'm closing this one due to separate repository here: https://github.com/getgrav/docker-grav |
No description provided.