Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker + docker-compose #844

Closed
wants to merge 17 commits into from
Closed

Conversation

FDiskas
Copy link

@FDiskas FDiskas commented May 20, 2016

No description provided.

@FDiskas
Copy link
Author

FDiskas commented May 20, 2016

You can run project first Install docker then install docker-compose

docker-compose up

To connect to container

docker exec -it getgrav bash

If you need a sudo just connect to container and type sudo apt-get update no password required

Windows or Mac user I would recomend to try Beta Docker

@rhukster
Copy link
Member

I would love to test this out, but alas, when i Try the new Beta Docker app, i get a nasty message about my 2008 Mac Pro being too old and not supported! Boo!!! I think it's time I get a new mac! Roll on WWDC!


COPY xdebug.ini /usr/local/etc/php/conf.d/xdebug.conf
COPY php.ini /usr/local/etc/php/php.ini
COPY vhost.conf /etc/apache2/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file (vhost.conf) looks like an nginx config file, am I missing something ?

RUN a2enmod ssl

# https://github.com/sameersbn/docker-gitlab/issues/396
RUN sed -i 's/host = uri.host/host = "http:\/\/rubygems.org"/g' /usr/lib/ruby/2.1.0/rubygems/remote_fetcher.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

libnotify-bin \
sudo

RUN docker-php-ext-install mbstring pdo_mysql zip gd curl intl mcrypt soap opcache json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the following line before:

RUN docker-php-ext-configure gd --with-freetype-dir=/usr/include/ --with-jpeg-dir=/usr/include/

Otherwise JPEG images were not processed.

@rhukster
Copy link
Member

While we like the idea of a built-in docker config, a couple of things come to mind.

  1. This really should be running on PHP7
  2. Webserver should be configured to run with same user/group as the files for minimal permissions issues
  3. Better if we don't put these files in the core itself, but have a CLI command in core that can pull latest docker files from a repo on github and run. That way we can ensure it's current and updated independently of the Grav core version running.

Some help with achieving these goals would be most welcome :)

@FDiskas
Copy link
Author

FDiskas commented Feb 10, 2017

I will check

@Jcambass
Copy link

Jcambass commented Mar 19, 2017

Any Updates on this? Would love to see an official automated Dockerfile for grav!

@rhukster I think the best way would be to just have an dockerfile in the project and setup an automated Dockerhub build that just builds a new Image on every push to the repo?

@FDiskas
Copy link
Author

FDiskas commented Mar 19, 2017

Give me one more week I can't find time for this right now

@Jcambass
Copy link

Sure. Hit me up if you need some help.

@FDiskas
Copy link
Author

FDiskas commented Apr 17, 2017

Ok, lets test the docker as is for now and then if it runs ok move it to docker HUB.
After all should be an grav CLI to run that docker.
I can made an example

@fnerdman
Copy link

fnerdman commented Aug 8, 2017

@np I've developed a grav image which I suggested to be added to the docker official images, they have no objections adding grav, but want upstream to take part of it

@FDiskas
Copy link
Author

FDiskas commented Sep 17, 2017

@Sylk
Copy link

Sylk commented Oct 13, 2017

Update please.

@Kasparsu
Copy link

Kasparsu commented Mar 9, 2018

update please. It is 2018 we want docker ;P

@Jucgshu
Copy link

Jucgshu commented Jun 22, 2018

Hi guys,

Just passing by to check if there's a will to provide an official Grav Docker image.

Cheers.

-j

@rhukster
Copy link
Member

when i get back from vacation, i'll take a look at this properly.

@rhukster rhukster self-assigned this Jun 22, 2018
@artemartemov
Copy link

@Jucgshu I haven't seen an official (@rhukster would know) but I have been using https://github.com/ericpoe/docker-grav-fpm locally only though. would be amazing to have one I can deploy as well :)

@Jucgshu
Copy link

Jucgshu commented Jun 23, 2018

Fantastic news @rhukster

-j

@Jucgshu
Copy link

Jucgshu commented Aug 4, 2018

Hate to be that guy, (but).

If you need beta testers, just ask.

-j

@xinity
Copy link

xinity commented Aug 27, 2018

hi there,
@FDiskas I've forked your repo and tried your docker PR, it is not working anymore sadly :(
based on your work, I've started another docker images, which you can try:
docker pull rzarouali/gravdev:develop (github repo to be pushed later today)

it's still a WIP , i'm working on having a smaller and faster image using php built-in server, which seems to be suitable for a simple usage. cc @rhukster

feel free to either rob some of the work i've done or suggest some tweaking on mine :)

let me know what works best for you

@rhukster
Copy link
Member

Ok, guys. I've started on this.. My aim is to have something as optimized as possible with only what is required in the 'official' docker image. Now i'm pretty new to Docker, so i'm having to learn this as I go along. I know you guys have more experience, so i'm going to be looking for help with this:

https://github.com/getgrav/docker-grav

Right now i JUST have a simple Dockerfile and although it's functional, I definitely want to improve it. When we're ready It needs to satisfy the requirements to be added to https://github.com/docker-library/official-images and https://github.com/docker-library/docs

Please see this issue for a list of things that still need to be done. I think we can use some of the contributions in this repo, as well as other official images like Drupal/Wordpress/Joomla etc to get some ideas of what an Official should and shouldn't have in them.

getgrav/docker-grav#1

@xinity
Copy link

xinity commented Sep 22, 2018

Let me help you on this then :)

On my way to the repo

@AntonLydike AntonLydike mentioned this pull request Aug 24, 2020
@mahagr
Copy link
Member

mahagr commented Feb 9, 2021

I'm closing this one due to separate repository here: https://github.com/getgrav/docker-grav

@mahagr mahagr closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.