Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Firefly widget #4683

Merged
merged 6 commits into from
Feb 2, 2025
Merged

Feature: Firefly widget #4683

merged 6 commits into from
Feb 2, 2025

Conversation

Amjad50
Copy link
Contributor

@Amjad50 Amjad50 commented Feb 1, 2025 •
edited
Loading

Proposed change

Created widget for Firefly III

image

Image of the demo profile

Closes #3598 (issue)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title Firefly widget Feature: Firefly widget Feb 1, 2025
@Amjad50
Add firefly iii widget
5800023 
Add new widget type, `firefly` which is implemented for `firefly iii` api,
to get some metadata about the account such as `net worth` and `budget` (first one)

Signed-off-by: Amjad Alsharafi <[email protected]>
@Amjad50
Documentation: Add firefly iii docs
a53357a 
Signed-off-by: Amjad Alsharafi <[email protected]>
shamoon
shamoon requested changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code improvements, otherwise seems good, thanks.

Screenshot 2025-02-01 at 5 46 02 PM

@Amjad50
Add firefly iii widget
46bb66e 
Add new widget type, `firefly` which is implemented for `firefly iii` api,
to get some metadata about the account such as `net worth` and `budget` (first one)

Signed-off-by: Amjad Alsharafi <[email protected]>
@Amjad50
Documentation: Add firefly iii docs
405e0fb 
Signed-off-by: Amjad Alsharafi <[email protected]>
@Amjad50 Amjad50 requested a review from shamoon February 2, 2025 02:00
@shamoon shamoon enabled auto-merge (squash) February 2, 2025 03:11
@shamoon shamoon merged commit cae304b into gethomepage:dev Feb 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amjad50 @shamoon