Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return all http routes of a namespace (k8s) #4865

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

arthur-leclerc
Copy link
Contributor

Proposed change

The Kubernetes integration was only returning a single HTTPRoute per namespace due to array destructuring in the listHttpRoute function. This limited the service discovery capabilities for users with multiple HTTPRoutes in the same namespace.

I don't quite understand why it was limited to one HTTPRoute per namespace, as it's certainly interesting to have multiple HTTPRoute in the same namespace, on one or more Gateway, and thus exposing multiple services on the Homepage. As a result, I have flagged this as a bug.

Closes # (issue)

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@arthur-leclerc arthur-leclerc changed the title fix: Returns all HTTPRoute of a namespace fix: Returns all HTTPRoute of a namespace (k8s) Mar 2, 2025
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeinstine @dudo any thoughts here?

@shamoon shamoon changed the title fix: Returns all HTTPRoute of a namespace (k8s) Fix: return all http routes of a namespace (k8s) Mar 2, 2025
@dudo
Copy link
Contributor

dudo commented Mar 3, 2025

Hello, Arthur! There are some assumptions made within the helpers about the first route. I think it's fair to assume that the schema will be the same for all routes within a resource. Good change!

@shamoon shamoon enabled auto-merge (squash) March 3, 2025 06:34
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to you both

@shamoon shamoon merged commit 99cde18 into gethomepage:dev Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants