Permalinks: look up from index if cache empty #6568
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@lukasbestle Implemented mostly as discussed in issue, though with
Cache::isEmpty()
instead of a special key to flag. However, I am very unsure if this really is a solution. Consider the scenario:false
cause it won't find the UUID in cache and is not allowed to use indexSo are we really solving the problem of the issue or in reality only postponing it one further request?
Summary of changes
Cache::isEmpty()
methodsReasoning
Additional context
Review commits one by one as the method reordering clutters the general diff.
Changelog
Fixes
Breaking changes
::isIndex(): bool
methodReady?
For review team