Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing title for toolbar buttons #6999

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Add missing title for toolbar buttons #6999

merged 1 commit into from
Feb 13, 2025

Conversation

bastianallgeier
Copy link
Member

Description

The <k-toolbar> component ignored button titles so far, which led to unlabelled icon buttons (e.g. in the blocks field options)

Summary of changes

  • The button.title is now being used if no label is set.

Fixes

Breaking changes

None

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier requested a review from a team February 13, 2025 10:35
@bastianallgeier bastianallgeier added this to the 4.7.0 milestone Feb 13, 2025
@bastianallgeier bastianallgeier merged commit bf8764f into develop-minor Feb 13, 2025
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6998-title-for-toolbar-buttons branch February 13, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative distantnative approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bastianallgeier @distantnative