fix: capture text highlighting on discard #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The `stopPaginationMode` and `stopGetList` functions in `src/context/browserActions.tsx` were updated to emit respective socket events (`'setPaginationMode'` and `'setGetList'`) with false flags after updating local state, ensuring socket state synchronization. In `src/components/recorder/RightSidePanel.tsx`, the `discardGetList` callback was enhanced to explicitly call `stopPaginationMode()` and `stopLimitMode()` to properly terminate pagination and limit modes when discarding a list capture. No other logic or exported entity declarations were changed.
## Changes
| Files | Change Summary |
|----------------------------------------------------|---------------------------------------------------------------------------------------------------------------------|
| src/context/browserActions.tsx | Added socket emission of `'setPaginationMode'` and `'setGetList'` events with false flags after updating local state |
| src/components/recorder/RightSidePanel.tsx | Added calls to `stopPaginationMode()` and `stopLimitMode()` within `discardGetList` callback to explicitly stop modes |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant RightSidePanel
participant BrowserActions
participant Socket
User->>RightSidePanel: discardGetList()
RightSidePanel->>RightSidePanel: stopPaginationMode()
RightSidePanel->>RightSidePanel: stopLimitMode()
RightSidePanel->>BrowserActions: stopGetList()
BrowserActions->>BrowserActions: set getList = false
BrowserActions->>Socket: emit 'setGetList' { getList: false }
BrowserActions->>BrowserActions: set paginationMode = false
BrowserActions->>Socket: emit 'setPaginationMode' { pagination: false }Assessment against linked issues
Possibly related PRs
Poem
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Fixes the issue where the highlighter displays selection for Capture List instead of Capture Text on discarding Capture List action
Fixes: #555
Summary by CodeRabbit