feat: add wait until timeout state for navigation

[amhsirak]

fixes #568

Summary by CodeRabbit

• Improvements
  • Enhanced page navigation reliability by ensuring actions wait for network activity to finish or timeout after 10 seconds. This affects both URL changes and browser state resets, potentially resulting in more consistent and stable user experiences.

[coderabbitai]

Walkthrough

The changes update the navigation logic in two server-side modules responsible for browser management. Both the URL change handler and the browser state reset function now include explicit options in their page navigation calls, specifying to wait until the network is idle and to apply a 10-second timeout. No changes were made to function signatures or exported entities. The rest of the logic, including error handling and logging, remains the same.

Changes

File(s)	Change Summary
server/src/browser-management/inputHandlers.ts	Updated handleChangeUrl to use page.goto with { waitUntil: 'networkidle', timeout: 10000 }
server/src/pgboss-worker.ts	Modified browser reset logic to use goto with the same navigation options

Assessment against linked issues

Objective	Addressed	Explanation
Prevent "Execution context destroyed because of navigation" error (#568)	✅

Poem

A hop and a skip through browser land,
With network idle, we firmly stand.
Ten seconds to wait, no more, no less,
For pages to load, and clear up the mess.
Bugs may have tried to lead us astray—
But with these tweaks, we bound on our way!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0de597d and ce0242e.

📒 Files selected for processing (2)

• server/src/browser-management/inputHandlers.ts (2 hunks)
• server/src/pgboss-worker.ts (1 hunks)

🔇 Additional comments (2)

server/src/browser-management/inputHandlers.ts (1)

405-405: Good enhancement to navigation reliability!

Adding { waitUntil: 'networkidle', timeout: 10000 } ensures the page navigation waits for network activity to settle (or times out after 10 seconds), which improves reliability by preventing premature action execution before the page is fully loaded.

server/src/pgboss-worker.ts (1)

96-96: Good consistency with navigation parameters!

Adding the same navigation options { waitUntil: 'networkidle', timeout: 10000 } to the browser reset function ensures consistent behavior with the URL change handler in inputHandlers.ts. This helps prevent state reset operations from proceeding before the navigation is complete.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.