Skip to content

[fix] 950 : restore and update compaction function & completes PR 985#994

Merged
Bl3f merged 2 commits into
mainfrom
fix/950_compaction_restored
Jun 30, 2026
Merged

[fix] 950 : restore and update compaction function & completes PR 985#994
Bl3f merged 2 commits into
mainfrom
fix/950_compaction_restored

Conversation

@socallmebertille

@socallmebertille socallmebertille commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • re-enables conversation compaction, which was temporarily disabled when image upload was introduced
  • fixes image token counting so compaction no longer kicks in too aggressively when a chat contains images
  • shows the animated nao logo while a conversation is being compacted, for consistency with the main loader
  • removes a leftover debug log

Related issue

#950

Which completes PR

#985

Review in cubic

@socallmebertille socallmebertille self-assigned this Jun 29, 2026
@socallmebertille socallmebertille changed the title [fix] 950 : restore and update compaction function [fix] 950 : restore and update compaction function & completes PR 985 Jun 29, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/backend/src/services/agent.ts
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview Removed

The preview deployment for this PR has been cleaned up.

@Bl3f Bl3f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bl3f
Bl3f merged commit cb57f9c into main Jun 30, 2026
7 checks passed
@Bl3f
Bl3f deleted the fix/950_compaction_restored branch June 30, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants