docs(benchmarks): verify crystal, elm, and ponyc targets#1311
Merged
Conversation
Record compare-outputs results for three new repository targets and tighten changelog copyright/holder/author junk filtering exposed while triaging crystal. Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Greptile SummaryThis PR updates benchmark documentation and compare-output triage artifacts. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "fix(copyright): keep junk filter out of ..." | Re-trigger Greptile |
Surface ScanCode/Provenant-favored file-metric triage queues and run-manifest durations from compare-outputs, start-anchor changelog copyright-year junk filtering, and keep the verify-benchmark-target skill pointed at those artifacts. Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@greptileai review |
mstykow
enabled auto-merge (squash)
July 19, 2026 17:23
Applying is_junk_copyright in refine_final_copyrights dropped many golden-expected notices that already match historical junk patterns. Changelog year-bump filtering still works via the existing detector junk path and the start-anchored patterns. Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare-outputsrepository targets not already indocs/BENCHMARKS.md:crystal-lang/crystal,elm/compiler, andponylang/ponyc.compare-outputstriage surface: flat ScanCode/Provenant-favored review queues,review_queue_summary, stdout triage pointer, andrun-manifest.jsonduration fields — so agents inspect artifacts instead of writing ad-hoc scripts.Scope and exclusions
shard.ymlpackage parser (tracked in Support parsing: Crystal shard.yml #1312; ScanCode also emits 0 packages on this snapshot); no broader literary-quote author cleanup on Elm'sQuotes.hs.How to verify
docs/BENCHMARKS.mdentries for present-tense end-state wording and alphabetical placement under Julia / Nix / Haskell / other ecosystems.cargo run --manifest-path xtask/Cargo.toml --bin compare-outputs -- --repo-url https://github.com/crystal-lang/crystal.git --repo-ref 82b5094b716b1e9a3f4fe6c601fd48272fc35d01 --profile common, and confirm (1) changelog copyright-year bullets stay absent and (2)comparison/samples/scancode_favored_review_queue.jsonplusrun-manifest.json*.duration_secsare present.Follow-up work
shard.ymlpackage extraction — Support parsing: Crystal shard.yml #1312.Expected-output fixture changes
Compare runs (local):
.provenant/compare-runs/20260719T171119Z-crystal-9555.provenant/compare-runs/20260719T171137Z-compiler-10473.provenant/compare-runs/20260719T171145Z-ponyc-11639Generated with Cursor.
Made with Cursor