Removed error prone key decode looping #7325
Open
+31
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoshiokatsuneo any clue who might be invested in / responsible for the authentication related code? |
redash/authentication/jwt_auth.py
Outdated
| else: | ||
| if url.startswith(FILE_SCHEME_PREFIX): | ||
| keys = [get_public_key_from_file(url)] | ||
| key = [get_signing_key_from_file(url)] |
There was a problem hiding this comment.
I just guess that "key" should not be an array.
@kuranium |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Old implementation could loop thru irrelevant public keys and trying to decode with them, causing unnecessary and missleading exceptions in logs.
In this commit the "net" fetched keys get filtered upon fetching, using the basic jwt functionality. So now we only use and cache keys with matching "kid" fields.
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)