test(slack): Trim runtime unit coverage#323
Merged
Merged
Conversation
Remove Slack runtime unit tests that duplicated integration coverage or asserted observability details. Keep the unit suite focused on local runtime handoff and ordering contracts. Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Slack runtime unit coverage that duplicated integration behavior tests or asserted observability details. The remaining unit suite now focuses on local runtime handoff and ordering checks, while the existing integration suites continue to own user-visible Slack behavior.
Testing Policy Alignment
Deletes the unit test that asserted
withSpanexecution and span context fields, since ordinary observability output is not a behavior contract underspecs/testing/index.md.Unit Scope
Keeps narrow unit checks for mention handoff, subscribed-message preparation order, conversation-context forwarding, and assistant lifecycle event forwarding. Subscribed-message skip/reply/opt-out/attachment/error behavior remains covered by the Slack integration suites.