fix(sandbox): Require OIDC config for egress proxy#353
Merged
Conversation
Fail sandbox credential egress setup before command execution when the deployment lacks the public proxy URL or Vercel OIDC verifier inputs. This prevents host-managed credentials from degrading into misleading provider 401s after the egress proxy is enabled. Document the required sandbox credential egress environment and add regressions for the missing callback URL, audience, and project ID cases. Co-Authored-By: GPT-5 Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f02f201. Configure here.
Keep sandbox claim validation scoped to the project and team values it checks. The full proxy setup still requires the trusted audience before credential egress is enabled, while token verification reuses that loaded config instead of reading it twice. Co-Authored-By: GPT-5 Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail sandbox credential egress setup before sandbox commands run when the deployment lacks the proxy callback URL or Vercel OIDC verifier configuration. This turns the recent egress regression into an explicit setup failure instead of letting GitHub traffic hit the provider with placeholder credentials and surface as 401s.
Egress Setup Contract
Credential egress policy construction now requires a public callback URL plus
VERCEL_OIDC_AUDIENCEandVERCEL_PROJECT_IDbefore provider forwarding is enabled.Regression Coverage
The sandbox egress proxy tests cover missing callback URL, audience, and project ID, and the config reference documents the required deployment environment.