feat: Update normalize func to replace node- prefixes with javascript- #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constantinius
approved these changes
Feb 4, 2025
Contributor
constantinius
left a comment
constantinius
left a comment
There was a problem hiding this comment.
Looks like a sensible solution.
ArthurKnaus
reviewed
Feb 4, 2025
Comment on lines
135
to
136
| node: "nodejs", | ||
| "node-awslambda": "awslambda", | ||
| "node-azurefunctions": "azure-functions", | ||
| "node-cloudflare-pages": "cloudflare", | ||
| "node-cloudflare-workers": "cloudflare", | ||
| "node-connect": "connect", | ||
| "node-express": "express", | ||
| "node-fastify": "fastify", | ||
| "node-gcpfunctions": "gcp-functions", | ||
| "node-hapi": "hapi", | ||
| "node-koa": "koa", | ||
| "node-nestjs": "nestjs", | ||
| "node-serverlesscloud": "serverless", | ||
| nvidia: "nvidia", |
Member
There was a problem hiding this comment.
I agree that we do this, just note that this is a breaking change and we need to bump to the next major version on release.
Member
Author
There was a problem hiding this comment.
yeap. I am aware of that :)
Co-authored-by: ArthurKnaus <[email protected]>
ArthurKnaus
approved these changes
Feb 4, 2025
This was referenced Feb 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will break the const platforms for users, but it’s likely only used in the Sentry icon stories. I considered adding
@deprecationwarning types, but since Object.keys() removes the types, it didn’t seem effective.Other than that, users using the component
<PlatformIcons />passing a platform with a 'node-' prefix will be unaffectedcontributes to
node-withjavascript-sentry#83988