Skip to content

Conversation

@Jesse-Box
Copy link
Contributor

  • Modified: Android svg art
  • Modified: Deno svg art
  • Modifed: Python svg art
  • Added: Langgraph icon

@Jesse-Box
Copy link
Contributor Author

Resolves issue #203 #199 #200

kotlin: "kotlin",
"kotlin-android": "android",
langchain: "langchain",
langgraph: "langgraph",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The code adds a mapping for the langgraph platform icon, but the corresponding SVG files are missing, which will cause a runtime error when the icon is loaded.
  • Description: A new mapping for langgraph is added to the PLATFORM_TO_ICON object. However, the corresponding SVG files (svg/langgraph.svg and svg_80x80/langgraph.svg) are not included in this change. When the PlatformIcon component attempts to render this icon, or when the preloadIcons() function is called, the dynamic require() call will fail to find the file. This will result in a MODULE_NOT_FOUND error at runtime, causing the application to crash.

  • Suggested fix: Add the missing langgraph.svg files to both the svg/ and svg_80x80/ directories to ensure they can be loaded at runtime by the PlatformIcon component.
    severity: 0.8, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shellmayr
Copy link
Member

Langgraph looks good 👍 but why is it purple-ish?

@Jesse-Box
Copy link
Contributor Author

Langgraph looks good 👍 but why is it purple-ish?

Their X profile has the same background color.

@Jesse-Box Jesse-Box merged commit 404bc7a into master Oct 1, 2025
7 checks passed
@Jesse-Box Jesse-Box deleted the feat/icons/android-deno-langgraph-python branch October 1, 2025 09:07
This was referenced Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants