-
-
Notifications
You must be signed in to change notification settings - Fork 20
feat/icons/android deno langgraph python #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jesse-Box
commented
Oct 1, 2025
- Modified: Android svg art
- Modified: Deno svg art
- Modifed: Python svg art
- Added: Langgraph icon
| kotlin: "kotlin", | ||
| "kotlin-android": "android", | ||
| langchain: "langchain", | ||
| langgraph: "langgraph", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The code adds a mapping for the langgraph platform icon, but the corresponding SVG files are missing, which will cause a runtime error when the icon is loaded.
-
Description: A new mapping for
langgraphis added to thePLATFORM_TO_ICONobject. However, the corresponding SVG files (svg/langgraph.svgandsvg_80x80/langgraph.svg) are not included in this change. When thePlatformIconcomponent attempts to render this icon, or when thepreloadIcons()function is called, the dynamicrequire()call will fail to find the file. This will result in aMODULE_NOT_FOUNDerror at runtime, causing the application to crash. -
Suggested fix: Add the missing
langgraph.svgfiles to both thesvg/andsvg_80x80/directories to ensure they can be loaded at runtime by thePlatformIconcomponent.
severity: 0.8, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
chargome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Langgraph looks good 👍 but why is it purple-ish? |
Their X profile has the same background color. |
