Skip to content

ref: add description that geo information is derived even if IP addre… #13828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented May 26, 2025

This PR adds a description to tell users that the geo information is not removed even if the "Prevent storing IP Addresses" toggle is enable and also tells them which Advanced scrubbing rule should be used to properly get rid of geo information in case it's desired.

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 7:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2025 7:52am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2025 7:52am

Copy link

codecov bot commented May 26, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/Coz8-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Coz8-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/vDZw9c6HTzuSCHu6s6Q4V/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/vDZw9c6HTzuSCHu6s6Q4V/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@tobias-wilfert tobias-wilfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@@ -56,6 +56,14 @@ Only a select number of fields are scrubbed. You can find a list of the fields t

In addition, we provide an [_Advanced Data Scrubbing_](/security-legal-pii/scrubbing//advanced-datascrubbing/) feature that allows more control over how filters are applied.

## Geo Information

Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to
Geographic information is extracted from the user's IP address. This occurs even if the setting to stop storing IP addresses is turned on.

## Geo Information

Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to
prevent storing IP addresses is enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prevent storing IP addresses is enabled.

@@ -56,6 +56,14 @@ Only a select number of fields are scrubbed. You can find a list of the fields t

In addition, we provide an [_Advanced Data Scrubbing_](/security-legal-pii/scrubbing//advanced-datascrubbing/) feature that allows more control over how filters are applied.

## Geo Information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Geo Information
## Geographic Information

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some rephrasing for clarity, otherwise looks good!

@Litarnus Litarnus merged commit 81ce879 into master Jun 3, 2025
13 checks passed
@Litarnus Litarnus deleted the martinl/geo-info-docs branch June 3, 2025 08:41
antonpirker pushed a commit that referenced this pull request Jun 6, 2025
#13828)

This PR adds a description to tell users that the geo information is not
removed even if the "Prevent storing IP Addresses" toggle is enable and
also tells them which Advanced scrubbing rule should be used to properly
get rid of geo information in case it's desired.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants