-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref: add description that geo information is derived even if IP addre… #13828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sses are not stored
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@@ -56,6 +56,14 @@ Only a select number of fields are scrubbed. You can find a list of the fields t | |||
|
|||
In addition, we provide an [_Advanced Data Scrubbing_](/security-legal-pii/scrubbing//advanced-datascrubbing/) feature that allows more control over how filters are applied. | |||
|
|||
## Geo Information | |||
|
|||
Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to | |
Geographic information is extracted from the user's IP address. This occurs even if the setting to stop storing IP addresses is turned on. |
## Geo Information | ||
|
||
Geo information is extracted based on the IP address of the user. This will happen independently of whether the setting to | ||
prevent storing IP addresses is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prevent storing IP addresses is enabled. |
@@ -56,6 +56,14 @@ Only a select number of fields are scrubbed. You can find a list of the fields t | |||
|
|||
In addition, we provide an [_Advanced Data Scrubbing_](/security-legal-pii/scrubbing//advanced-datascrubbing/) feature that allows more control over how filters are applied. | |||
|
|||
## Geo Information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Geo Information | |
## Geographic Information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some rephrasing for clarity, otherwise looks good!
#13828) This PR adds a description to tell users that the geo information is not removed even if the "Prevent storing IP Addresses" toggle is enable and also tells them which Advanced scrubbing rule should be used to properly get rid of geo information in case it's desired.
This PR adds a description to tell users that the geo information is not removed even if the "Prevent storing IP Addresses" toggle is enable and also tells them which Advanced scrubbing rule should be used to properly get rid of geo information in case it's desired.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES