Skip to content

🔧 chore(integrations): recommend using service accounts when installing integrations that use personal tokens #13912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented Jun 3, 2025

DESCRIBE YOUR PR

The Azure DevOps and Gitlab integration uses personal access tokens for authentication, which means all integration activities (comments, work item creation, commit associations) are attributed to the individual user who installed the integration. This can cause several issues:

  • Activities appear to come from a specific person rather than the system
  • Integration may break when that person leaves the organization

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Azure

image

Gitlab

image

@iamrajjoshi iamrajjoshi self-assigned this Jun 3, 2025
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 8:52pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2025 8:52pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2025 8:52pm

@iamrajjoshi iamrajjoshi requested a review from a team June 3, 2025 18:57
Copy link

codecov bot commented Jun 3, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/UUcjlFynziSzMpgcdcfMH/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/UUcjlFynziSzMpgcdcfMH/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/_6ZDqLQCzeM_lsFNeSGY3/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/_6ZDqLQCzeM_lsFNeSGY3/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@iamrajjoshi iamrajjoshi merged commit 295fc45 into master Jun 3, 2025
13 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/reccomend-use-service-accounts branch June 3, 2025 23:23
antonpirker pushed a commit that referenced this pull request Jun 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants