Skip to content

fix(Apple): Updates in-app frames page to reflect reality #13918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

kahest
Copy link
Member

@kahest kahest commented Jun 4, 2025

DESCRIBE YOUR PR

Updates in-app frames page for Apple to reflect reality.

came up in getsentry/sentry-cocoa#5252

fixes getsentry/sentry-cocoa#5351

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@codeowner-assignment codeowner-assignment bot requested a review from a team June 4, 2025 13:09
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 2:01pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:01pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:01pm

Copy link

codecov bot commented Jun 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/3vUYlG_Pp5CIqnNsoJhC0/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/3vUYlG_Pp5CIqnNsoJhC0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6DoFBVrbj7AlKP9N0ds6w/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/6DoFBVrbj7AlKP9N0ds6w/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it might be valuable to mention why the existing text is commented instead of removed.

@codeowner-assignment codeowner-assignment bot requested a review from a team June 4, 2025 13:43
@kahest kahest enabled auto-merge (squash) June 4, 2025 13:58
@kahest kahest merged commit 076ab90 into master Jun 4, 2025
13 checks passed
@kahest kahest deleted the kahest/apple-in-app-frames branch June 4, 2025 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to reflect actual in-app stack trace marking logic
2 participants