Skip to content

feat(electron): Document structured logging for the Electron SDK #13925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

Documents getsentry/sentry-electron#1159

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: June 9
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested review from timfish and Copilot June 4, 2025 17:44
@AbhiPrasad AbhiPrasad self-assigned this Jun 4, 2025
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 6:00pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Jun 4, 2025 6:00pm
develop-docs ⬜️ Ignored (Inspect) Jun 4, 2025 6:00pm

@AbhiPrasad AbhiPrasad review requested due to automatic review settings June 4, 2025 17:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Documents the newly added structured logging feature for the Electron SDK by adding dedicated includes and updating the public-facing docs.

  • Introduces platform-includes files for Electron logs (usage, setup, requirements, integrations).
  • Adds an Electron entry to the “Getting Started” logs guide.
  • Marks Electron as supported by removing it from the common logs notSupported list.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
platform-includes/logs/usage/javascript.electron.mdx Include usage guide for Electron structured logs
platform-includes/logs/setup/javascript.electron.mdx Add setup instructions and code snippets for main/renderer processes
platform-includes/logs/requirements/javascript.electron.mdx Specify minimum Electron SDK version that supports logging
platform-includes/logs/integrations/javascript.electron.mdx Include console-logging integration guide
docs/product/explore/logs/getting-started/index.mdx Add Electron to supported SDKs list and remove outdated placeholder
docs/platforms/javascript/common/logs/index.mdx Remove Electron from the notSupported list

Copy link

codecov bot commented Jun 4, 2025

Bundle Report

Changes will increase total bundle size by 831 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB 837 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 282 bytes 398.87kB 0.07%
../app/platform-redirect/page.js.nft.json 282 bytes 398.78kB 0.07%
../app/sitemap.xml/route.js.nft.json 282 bytes 396.75kB 0.07%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/-*.js (New) 616 bytes 616 bytes 100.0% 🚀
static/sFY_Ih5kxwJYejnHK3vKV/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/sFY_Ih5kxwJYejnHK3vKV/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@AbhiPrasad AbhiPrasad merged commit 3a1cc76 into master Jun 4, 2025
13 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-logs-electron-docs branch June 4, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants