-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(python): Update tracing troubleshooting for SDK 3.0 #14436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Update tracing troubleshooting for SDK 3.0 #14436
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 603 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: URL Construction Error: Double Slashes
The URL construction in the make_request
call results in a malformed URL with double slashes. The endpoint
variable already starts with a leading slash, but the format string "{base_url}/{endpoint}/"
adds an additional slash, creating URLs like https://empowerplant.io//api/0/projects/ep/setup_form/
. The format string should be "{base_url}{endpoint}/"
.
docs/platforms/python/tracing/troubleshooting/index__v3.x.mdx#L86-L91
make_request( | |
"{base_url}/{endpoint}/".format( | |
base_url=base_url, | |
endpoint=endpoint, | |
), | |
data=parameters, |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Created a new copy of the Tracing > Troubleshooting page for the upcoming SDK 3.0 with the following changes: - changed `set_data` to `set_attribute`
Created a new copy of the Tracing > Troubleshooting page for the upcoming SDK 3.0 with the following changes:
set_data
toset_attribute
Direct link to preview: https://sentry-docs-git-ivana-pythonupdate-tracing-troubleshooti-83bb43.sentry.dev/platforms/python/tracing/troubleshooting__v3.x
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES