Skip to content

fixing some errors from nextjs-source-map-updates branch #14467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sfanahata
Copy link
Contributor

DESCRIBE YOUR PR

  • Fix enabled/disabled typo
  • Make clear that default: true is the default
  • Make clearer that source maps options are optional for set-up

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@sfanahata sfanahata requested a review from chargome July 25, 2025 19:14
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2025 7:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 7:45pm

@sfanahata
Copy link
Contributor Author

@chargome - adding the fixes I missed on the nextjs source maps repo.

Copy link

codecov bot commented Jul 25, 2025

Bundle Report

Changes will increase total bundle size by 180 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.26MB 186 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.71kB -0.0%
static/chunks/1831-*.js -3 bytes 422.23kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/RkcLbZq6XPN2jAOxFhW2K/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/RkcLbZq6XPN2jAOxFhW2K/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ArR_RJs_UE6kebFdtMqx_/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ArR_RJs_UE6kebFdtMqx_/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 65 bytes 730.07kB 0.01%
../app/platform-redirect/page.js.nft.json 65 bytes 729.98kB 0.01%
../app/sitemap.xml/route.js.nft.json 65 bytes 727.46kB 0.01%

@@ -46,7 +46,7 @@ module.exports = withSentryConfig(
project: "___PROJECT_SLUG___",
authToken: process.env.SENTRY_AUTH_TOKEN,
sourcemaps: {
disable: false, // Enable source maps (default: false)
disable: false, // Enables source maps (default = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just find the wording confusing :D

The disable option disables sourcemaps. This option is false by default (sourcemaps are uploaded per default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants