Conversation
Adds a framework-agnostic module that owns the canonical default sensitive
key lists, the redaction placeholder, the credit-card detection heuristic,
and the recursive map/list traversal used to scrub data before it is sent
to Sentry. Existing integrations duplicate these primitives today; this
module provides a single source of truth that follow-up commits will route
PlugContext, PlugCapture, and LiveViewHook through.
The default behavior matches the existing Sentry.PlugContext defaults
("*********" placeholder, ["password", "passwd", "secret"] for params,
["authorization", "authentication", "cookie"] for headers) so no
existing scrubbing output changes.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Removes the duplicated denylist constants, placeholder, credit-card regex, and recursive scrub_map/scrub_list helpers from Sentry.PlugContext in favor of the shared Sentry.Scrubber module. Public function signatures and the documented default key sets are unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
solnic
force-pushed
the
refa/extract-scrubber
branch
from
c9388da to
ee7d131
Compare
whatyouhide
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just extracts default scrubber so that we will be able to use it in live view scrubbing too (see follow-up #1048 that relies on this one).
Eventually, we'll fully implement scrubbing/data collection API to conform to the upcoming data collection spec.