-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Slog integration #865
base: master
Are you sure you want to change the base?
Add Slog integration #865
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 83.01% 83.21% +0.20%
==========================================
Files 51 54 +3
Lines 5433 5756 +323
==========================================
+ Hits 4510 4790 +280
- Misses 767 804 +37
- Partials 156 162 +6 ☔ View full report in Codecov by Sentry. |
@cleptric Just realised we can't use 1.18 with exp/slog (requires at least 1.19): golang/go#57113 |
Will this be merged? |
Yes. We're holding off merging new features for a week or so to give us time to fix potential issues in 0.29.0. Afterwards, we'll get this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry.
I updated .craft.yml and made |
Just CI needs to pass and then we can get this merged 🙂 |
@cleptric Shall I update the |
Waiting for #898 to be merged before I merge this. |
Resolves #527