fix(breadcrumbs): Deduplicate battery breadcrumbs #4561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano,
markushi and
lcian
as code owners
Performance metrics 🚀
|
markushi
approved these changes
Jul 22, 2025
| return Objects.hash(roundedLevel, charging); | ||
| } | ||
|
|
||
| private boolean isSimilarLevel(final @Nullable Float level1, final @Nullable Float level2) { |
There was a problem hiding this comment.
IMHO I'd rather store the battery level as an integer value directly, saves us some extra logic. I guess it's fine to have the breadcrumb report an integer value too.
There was a problem hiding this comment.
yeah sounds good, I also was hesitating with this logic tbh. Will adjust 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes getsentry/sentry-react-native#4668
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps