Profiling - OTEL profiling fix, Stabilization, Logging #4746

lbloder · 2025-09-23T08:12:41Z

Sets profilerId in SpanContext when span/transaction is created by OTEL
- Scopes do not start profiler if profilerId already in SpanContext
Stop profiler immediately instead of waiting for the 10s timeout to occur
Drop single event (sample) instead of whole chunk if any exception occurs during processing.
Improved error handling
Fixes for issues discovered in previous PR

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…ling and handle cases where profiling has been started by otel

…te this to the exporter and SentryTracer

…ion exceptions in provider

github-actions · 2025-09-23T08:13:02Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-23T08:13:08Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Profiling - OTEL profiling fix, Stabilization, Logging ([#4746](https://github.com/getsentry/sentry-java/pull/4746))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 2295cba

github-actions · 2025-09-23T08:23:31Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	366.26 ms	417.02 ms	50.77 ms
Size	1.58 MiB	2.09 MiB	521.70 KiB

Baseline results on branch: feat/continuous-profiling-03

Startup times

Revision	Plain	With Sentry	Diff
`42206f4`	419.73 ms	494.82 ms	75.09 ms
`066d89d`	377.51 ms	434.20 ms	56.69 ms
`d6f8356`	392.08 ms	454.42 ms	62.34 ms
`7dcbbbd`	459.22 ms	509.85 ms	50.62 ms
`f2cd43a`	415.48 ms	485.28 ms	69.80 ms

App size

Revision	Plain	With Sentry	Diff
`42206f4`	1.58 MiB	2.09 MiB	521.84 KiB
`066d89d`	1.58 MiB	2.09 MiB	521.85 KiB
`d6f8356`	1.58 MiB	2.09 MiB	521.68 KiB
`7dcbbbd`	1.58 MiB	2.09 MiB	521.68 KiB
`f2cd43a`	1.58 MiB	2.09 MiB	521.84 KiB

Previous results on branch: feat/continuous-profiling-04

Startup times

Revision	Plain	With Sentry	Diff
`5c219a7`	360.48 ms	423.72 ms	63.24 ms
`360cb4c`	361.89 ms	418.44 ms	56.54 ms

App size

Revision	Plain	With Sentry	Diff
`5c219a7`	1.58 MiB	2.09 MiB	521.70 KiB
`360cb4c`	1.58 MiB	2.09 MiB	521.69 KiB

github-actions · 2025-09-23T12:35:12Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

…entry-java into feat/continuous-profiling-04

github-actions · 2025-09-23T12:43:20Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

github-actions · 2025-09-23T14:49:54Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

sentry/src/main/java/io/sentry/transport/RateLimiter.java

lbloder · 2025-09-23T14:51:28Z

@sentry review

lbloder · 2025-09-23T14:51:33Z

cursor review

.../src/main/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverter.java

...y-async-profiler/src/main/java/io/sentry/asyncprofiler/profiling/JavaContinuousProfiler.java

sentry/src/main/java/io/sentry/SpanContext.java

sentry/src/main/java/io/sentry/SentryTracer.java

adinauer

LGTM

adinauer · 2025-09-25T10:21:27Z

...rc/test/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverterTest.kt

+    val minTimestamp = samples.minOf { it.timestamp }
+    val maxTimestamp = samples.maxOf { it.timestamp }
+    val sampleTimeStamp =
+      DateUtils.nanosToDate((maxTimestamp * 1000 * 1000 * 1000).toLong()).toInstant()


l Could use DateUtils.secondsToNanos

...rc/test/java/io/sentry/asyncprofiler/convert/JfrAsyncProfilerToSentryProfileConverterTest.kt

* add readme and info about commit of the source repository * delete jfr file on jvm exit * further split into smaller methods * deduplicate frames in order to save bandwidth, add converter tests * remove Platform Enum, use string constants instead for compatibility with cross platform frameworks * implement equals and hashcode for SentryStackFrame to make frame deduplication work * bump api * improve error handling, fix start stop start flow * add new testfile * calculate ticksPerNanosecond in constructor * adapt Ratelimiter to check for both ProfileChunk and ProfileChunkUi ratelimiting * update ratelimiter test to check for both profileChunk and profileChunkUi drops * use string constant instead of string * Format code * add non aggregating event collector to send each event individually, deduplicate stacks * adapt converter tests to new non-aggregated converter * Format code * add logging to loadProfileConverter * Format code * fix duplication of events * catch all exception happening when converting from jfr * add exists and writable info to log message * add method to safely delete file * remove setNative call * fix test * fix reference to commit we vendored from * drop event if it cannot be processed to not lose the whole chunk * make format * fix test * Format code * Profiling - OTEL profiling fix, Stabilization, Logging (#4746) * add skipProfiling flag to TransactionOptions to be able to skip profiling and handle cases where profiling has been started by otel * add profilerId to spanContext so that otel span processor can propagate this to the exporter and SentryTracer * immediately end profiling when stopProfiler is called * bump api, fix android api 24 code * catch all exception happening when converting from jfr * simplify JavaContinuous profiler by catching AsyncProfiler instantiation exceptions in provider * add exists and writable info to log message * add method to safely delete file * remove setNative call * fix test * fix reference to commit we vendored from * drop event if it cannot be processed to not lose the whole chunk * Format code * fix test * Format code * fix test * catch exceptions in startProfiler/stopProfiler * fallback to threadId -1 if it cannot be resolved --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]>

* delete unused JfrFrame and JfrToSentryProfileconverter * use passed-in profilingTracesHz parameter instead of hardcoded value * start profiler before starting the transaction when ProfileLifecycle.TRACE is used to have the profile ID when SentryTracer is created * use improved way to calculate timestamp of sample * api dump * let profile-lifecycle be set from external_options, add tests for SpringBoot autoconfig * initialize stackTraceFactory only once per chunk * rename profile data classes, add deserialization and tests * extract methods in ProfileConverter, fix SentryProfile serialization and make fields private * use wall=[interval] instead of setting the event to wall and setting the interval separately, this seems to work better and create more samples * start/stop profiler in OtelSentrySpanProcesser in trace mode for root spans * add profiler dependency to jakarta-opentelemetry sample, add needed configs * add dependenies and config to spring-boot-jakarta sample * remove connection status check * extract event visitor * Add enum for ProfileChunk platform * fallback to default temp directory for profiling on jvm if directory is not configured * cleanup some minor things * remove ProfilingInitializer, fix comments * Format code * add getter/setter to sample and metadata * fix compile error * add comment/todo for deleteOnExit * Profiling - Deduplication and cleanup (#4681) * add readme and info about commit of the source repository * delete jfr file on jvm exit * further split into smaller methods * deduplicate frames in order to save bandwidth, add converter tests * remove Platform Enum, use string constants instead for compatibility with cross platform frameworks * implement equals and hashcode for SentryStackFrame to make frame deduplication work * bump api * improve error handling, fix start stop start flow * add new testfile * calculate ticksPerNanosecond in constructor * adapt Ratelimiter to check for both ProfileChunk and ProfileChunkUi ratelimiting * update ratelimiter test to check for both profileChunk and profileChunkUi drops * use string constant instead of string * Format code * add non aggregating event collector to send each event individually, deduplicate stacks * adapt converter tests to new non-aggregated converter * Format code * add logging to loadProfileConverter * Format code * fix duplication of events * catch all exception happening when converting from jfr * add exists and writable info to log message * add method to safely delete file * remove setNative call * fix test * fix reference to commit we vendored from * drop event if it cannot be processed to not lose the whole chunk * make format * fix test * Format code * Profiling - OTEL profiling fix, Stabilization, Logging (#4746) * add skipProfiling flag to TransactionOptions to be able to skip profiling and handle cases where profiling has been started by otel * add profilerId to spanContext so that otel span processor can propagate this to the exporter and SentryTracer * immediately end profiling when stopProfiler is called * bump api, fix android api 24 code * catch all exception happening when converting from jfr * simplify JavaContinuous profiler by catching AsyncProfiler instantiation exceptions in provider * add exists and writable info to log message * add method to safely delete file * remove setNative call * fix test * fix reference to commit we vendored from * drop event if it cannot be processed to not lose the whole chunk * Format code * fix test * Format code * fix test * catch exceptions in startProfiler/stopProfiler * fallback to threadId -1 if it cannot be resolved --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]> --------- Co-authored-by: Sentry Github Bot <[email protected]>

lbloder added 12 commits September 15, 2025 14:20

add skipProfiling flag to TransactionOptions to be able to skip profi…

1cb3cad

…ling and handle cases where profiling has been started by otel

add profilerId to spanContext so that otel span processor can propaga…

d9790e3

…te this to the exporter and SentryTracer

immediately end profiling when stopProfiler is called

b86145b

bump api, fix android api 24 code

9b4d2e1

catch all exception happening when converting from jfr

732894f

simplify JavaContinuous profiler by catching AsyncProfiler instantiat…

cde0eb1

…ion exceptions in provider

add exists and writable info to log message

c694f0c

add method to safely delete file

9f941dd

remove setNative call

e45ee44

fix test

797f468

fix reference to commit we vendored from

b882020

drop event if it cannot be processed to not lose the whole chunk

d9fc89e

Format code

ecc0215

lbloder mentioned this pull request Sep 23, 2025

Profiling - Deduplication and cleanup #4681

Merged

8 tasks

fix test

ab9b950

getsentry-bot and others added 4 commits September 23, 2025 12:38

Format code

16ad3ac

fix test

eb6a942

catch exceptions in startProfiler/stopProfiler

0b1ea35

Merge branch 'feat/continuous-profiling-04' of github.com:getsentry/s…

802e79e

…entry-java into feat/continuous-profiling-04

fallback to threadId -1 if it cannot be resolved

2295cba

This comment was marked as outdated.

Sign in to view

seer-by-sentry bot reviewed Sep 23, 2025

View reviewed changes

adinauer approved these changes Sep 25, 2025

View reviewed changes

lbloder marked this pull request as ready for review September 26, 2025 06:59

lbloder requested review from romtsn, stefanosiano, markushi and lcian as code owners September 26, 2025 06:59

lbloder merged commit 242ca41 into feat/continuous-profiling-03 Sep 26, 2025
31 of 36 checks passed

lbloder deleted the feat/continuous-profiling-04 branch September 26, 2025 08:26

Uh oh!

Profiling - OTEL profiling fix, Stabilization, Logging #4746

Profiling - OTEL profiling fix, Stabilization, Logging #4746

Conversation

lbloder commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instructions and example for changelog

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: feat/continuous-profiling-03

Startup times

App size

Previous results on branch: feat/continuous-profiling-04

Startup times

App size

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions bot commented Sep 23, 2025

🚨 Detected changes in high risk code 🚨

Uh oh!

lbloder commented Sep 23, 2025

Uh oh!

lbloder commented Sep 23, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adinauer left a comment

Choose a reason for hiding this comment

Uh oh!

adinauer Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lbloder commented Sep 23, 2025 •

edited

Loading

github-actions bot commented Sep 23, 2025 •

edited

Loading

github-actions bot commented Sep 23, 2025 •

edited

Loading